OP-TEE March 2021

op-tee@lists.trustedfirmware.org

24 participants
27 discussions

by Ran Wang

This patch add ACPI support for optee driver. Signed-off-by: Ran Wang <ran.wang_1(a)nxp.com> --- drivers/tee/optee/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index cf4718c6d35d..8fb261f4b9db 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -5,6 +5,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include <linux/acpi.h> #include <linux/arm-smccc.h> #include <linux/errno.h> #include <linux/io.h> @@ -735,12 +736,21 @@ static const struct of_device_id optee_dt_match[] = { }; MODULE_DEVICE_TABLE(of, optee_dt_match); +#ifdef CONFIG_ACPI +static const struct acpi_device_id optee_acpi_match[] = { + { "OPTEE01",}, + { }, +}; +MODULE_DEVICE_TABLE(acpi, dwc3_acpi_match); +#endif + static struct platform_driver optee_driver = { .probe = optee_probe, .remove = optee_remove, .driver = { .name = "optee", .of_match_table = optee_dt_match, + .acpi_match_table = ACPI_PTR(optee_acpi_match), }, }; module_platform_driver(optee_driver); -- 2.25.1

5 years

EHF + OPTEE on ARM64

by Peng Fan

Hi, In bl31/ehf.c, there are following two lines, per my understanding, when cpu is in secure world, the non-secure interrupt as FIQ(GICv3) will be directly catched by EL3, not S-EL1 /* Route EL3 interrupts when in Secure and Non-secure. */ set_interrupt_rm_flag(flags, NON_SECURE); set_interrupt_rm_flag(flags, SECURE); So this will conflict with OP-TEE, because OP-TEE needs catch NS-interrupt as FIQ in S-EL1 world. Am I understand correct? Any ideas how we could address this to make EHF + OPTEE run together? Thanks Peng.

5 years, 1 month

Re: EHF + OPTEE on ARM64

by Jelle Sels

Hi, If I am not mistaking, the fiq handler should be opteed_sel1_interrupt_handler which will forward the interrupt to S-EL1. R, Jelle ________________________________________ From: OP-TEE <op-tee-bounces(a)lists.trustedfirmware.org> on behalf of Peng Fan via OP-TEE <op-tee(a)lists.trustedfirmware.org> Sent: Tuesday, March 16, 2021 11:08 To: op-tee(a)lists.trustedfirmware.org; Jens Wiklander; Joakim Bech Subject: EHF + OPTEE on ARM64 Hi, In bl31/ehf.c, there are following two lines, per my understanding, when cpu is in secure world, the non-secure interrupt as FIQ(GICv3) will be directly catched by EL3, not S-EL1 /* Route EL3 interrupts when in Secure and Non-secure. */ set_interrupt_rm_flag(flags, NON_SECURE); set_interrupt_rm_flag(flags, SECURE); So this will conflict with OP-TEE, because OP-TEE needs catch NS-interrupt as FIQ in S-EL1 world. Am I understand correct? Any ideas how we could address this to make EHF + OPTEE run together? Thanks Peng.

5 years, 1 month

[PATCH] drivers: tee: optee: removed repeated words in comments

by Anupama K Patil

the word "the" is repeated in the file core.c so it has been removed. Likewise the word "of" is repeated in optee_smc.h and have removed it. Signed-off-by: Anupama K Patil <anupamakpatil123(a)gmail.com> --- drivers/tee/optee/core.c | 2 +- drivers/tee/optee/optee_smc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index cf4718c6d35d..2ccb091cd643 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -422,7 +422,7 @@ static bool optee_msg_exchange_capabilities(optee_invoke_fn *invoke_fn, /* * TODO This isn't enough to tell if it's UP system (from kernel - * point of view) or not, is_smp() returns the the information + * point of view) or not, is_smp() returns the information * needed, but can't be called directly from here. */ if (!IS_ENABLED(CONFIG_SMP) || nr_cpu_ids == 1) diff --git a/drivers/tee/optee/optee_smc.h b/drivers/tee/optee/optee_smc.h index 80eb763a8a80..49e8e027dc5b 100644 --- a/drivers/tee/optee/optee_smc.h +++ b/drivers/tee/optee/optee_smc.h @@ -162,7 +162,7 @@ struct optee_smc_call_get_os_revision_result { * Have config return register usage: * a0 OPTEE_SMC_RETURN_OK * a1 Physical address of start of SHM - * a2 Size of of SHM + * a2 Size of SHM * a3 Cache settings of memory, as defined by the * OPTEE_SMC_SHM_* values above * a4-7 Preserved -- 2.25.1

5 years, 1 month

Re: Request for support opensource optee contribution guide line

by Jens Wiklander

Hi Raghu, On Wed, Mar 3, 2021 at 8:38 AM Yejerla, VeeraraghavuluX via OP-TEE <op-tee(a)lists.trustedfirmware.org> wrote: > > Dear Sir, > > I would like to know that, if I want submit any patch for optee opensource features, could please guide me what are the guide line I have to follow it. Below are some information require . > > > 1. What is the maximum patch size shall I submit? That depends, it might be good to start with something small as a first contribution. > 2. What are the code guide line I have to follow it? https://optee.readthedocs.io/en/latest/general/coding_standards.html > 3. What are mail chain I have to include for patch review purpose? > 4. Is there any open source link for post quarry ? See https://optee.readthedocs.io/en/latest/general/contribute.html Cheers, Jens

5 years, 1 month

Re: Linaro OP-TEE Contributions meeting February 2021

by Jens Wiklander

Hi, On Fri, Feb 26, 2021 at 9:50 AM Jérôme Forissier via OP-TEE <op-tee(a)lists.trustedfirmware.org> wrote: > > Hi, > > On Thu, Feb 25, 2021 at 9:41 AM Joakim Bech via OP-TEE < > op-tee(a)lists.trustedfirmware.org> wrote: > > > Hi Jorge, > > > > On Wed, 24 Feb 2021 at 18:14, Jorge Ramirez <jorge(a)foundries.io> wrote: > > > > > Sorry Joakim. > > > I guess it is too late now but It would have been good to talk about the > > > TEE strategy/direction with RNG. > > > 1) how often do we seed the PRNG. > > > 2) should we always use PRNG and only use HWRNG to seed if with a certain > > > cadence. > > > 3) how do we measure the quality of an RNG in OPTEE (how do we guarantee > > > no regressions) > > > this would be really an open discussion more than anything else (unless > > > there is a matematician amongst us) > > > > > Yes, good suggestions. I'll add it to the next meeting (March 25:th). > > > > And now that I think of it... there is this big OCALL contribution that has > been mostly stalled for months... > https://github.com/OP-TEE/optee_os/pull/3673 > We should discuss what to do with it. Yes, the kernel part is the hard part here. Cheers, Jens

5 years, 1 month

Request for support opensource optee contribution guide line

by Yejerla, VeeraraghavuluX

Dear Sir, I would like to know that, if I want submit any patch for optee opensource features, could please guide me what are the guide line I have to follow it. Below are some information require . 1. What is the maximum patch size shall I submit? 2. What are the code guide line I have to follow it? 3. What are mail chain I have to include for patch review purpose? 4. Is there any open source link for post quarry ? Regards, Raghu

5 years, 1 month

2026

2025

2024

2023

2022

2021

2020

OP-TEE March 2021