- OP-TEE - lists.trustedfirmware.org

[GIT PULL] Fix possible memory leak OP-TEE driver for v6.1

by Jens Wiklander

Hello arm-soc maintainers, Please pull this small patch in the OP-TEE driver which fixes a possible memory leak in the error path of optee_register_device(). Thanks, Jens The following changes since commit 094226ad94f471a9f19e8f8e7140a09c2625abaa: Linux 6.1-rc5 (2022-11-13 13:12:55 -0800) are available in the Git repository at: https://git.linaro.org/people/jens.wiklander/linux-tee.git tags/optee-fix-for-6.1 for you to fetch changes up to cce616e012c215d65c15e5d1afa73182dea49389: tee: optee: fix possible memory leak in optee_register_device() (2022-11-17 09:22:12 +0100) ---------------------------------------------------------------- Fix possible memory leak in optee_register_device() ---------------------------------------------------------------- Yang Yingliang (1): tee: optee: fix possible memory leak in optee_register_device() drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

3 years, 11 months

1
0
0 0

[PATCH] tee: optee: fix possible memory leak in optee_register_device()

by ruanjinjie

If device_register() returns error in optee_register_device(), name of kobject which is allocated in dev_set_name() called in device_add() is leaked. Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Fixes: c3fa24af9244 ("tee: optee: add TEE bus device enumeration support") Signed-off-by: ruanjinjie <ruanjinjie(a)huawei.com> --- drivers/tee/optee/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tee/optee/device.c b/drivers/tee/optee/device.c index f3947be13e2e..64f0e047c23d 100644 --- a/drivers/tee/optee/device.c +++ b/drivers/tee/optee/device.c @@ -80,7 +80,7 @@ static int optee_register_device(const uuid_t *device_uuid) rc = device_register(&optee_device->dev); if (rc) { pr_err("device registration failed, err: %d\n", rc); - kfree(optee_device); + put_device(&optee_device->dev); } return rc; -- 2.25.1

3 years, 11 months

2
1
0 0

Linaro OP-TEE Contribution (LOC) monthly meeting November 22

by Jens Wiklander

Hi, For time and connection details see the calendar at https://www.trustedfirmware.org/meetings/ I have one topic for the LOC: Can we deprecate paging of OP-TEE on Armv8-A platforms using FF-A? Any other topic? Thanks, Jens

3 years, 11 months

1
0
0 0

[PATCH] tee: optee: Populate child nodes in probe function

by Ludvig Pärsson

Currently there is no dependency between the "linaro,scmi-optee" driver and the tee_core. If the scmi-optee driver gets probed before the tee_bus_type is initialized, then we will get an unwanted error print. This patch enables putting scmi-optee nodes as children to the optee node in devicetree, which indirectly creates the missing dependency. Signed-off-by: Ludvig Pärsson <ludvig.parsson(a)axis.com> --- drivers/tee/optee/smc_abi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c index a1c1fa1a9c28..be6f02fd5a7f 100644 --- a/drivers/tee/optee/smc_abi.c +++ b/drivers/tee/optee/smc_abi.c @@ -1533,6 +1533,11 @@ static int optee_probe(struct platform_device *pdev) if (rc) goto err_disable_shm_cache; + /* Populate any dependent child node (if any) */ + rc = devm_of_platform_populate(&pdev->dev); + if (rc) + goto err_disable_shm_cache; + pr_info("initialized driver\n"); return 0; -- 2.30.2

3 years, 11 months

4
6
0 0

Linaro OP-TEE Contribution (LOC) monthly meeting October

by Jens Wiklander

Hi, OP-TEE Contributions (LOC) monthly meeting is planned for Tuesday, Oct 25 at 10.00 (UTC). Note, new time! If you have any topics you'd like to discuss, please let us know and we can schedule them. Meeting details: Date/time: October 25 at 10.00 (UTC) Meeting notes: http://bit.ly/loc-notes Project page: https://www.linaro.org/projects/#LOC Connection details =============== Join Zoom: https://linaro-org.zoom.us/j/93697277554?pwd=MGdFRU4xZjdDS2VSMzVMbGZIdnkwZz… Thanks, Jens on behalf of the Linaro OP-TEE team

3 years, 11 months

2
2
0 0

OP-TEE 3.19 SPMC status

by Balint Dobszay

Hi All, This is a follow-up email to the OP-TEE 3.19 release, highlighting the updates to the SPMC and related components. Short summary of introduced changes: - Added support for running SPs loaded from the FIP (by TF-A). This is an alternative to the current embedded SP loading mechanism [1]. - Added a new suite to xtest (ffa_spmc) to enable testing the SPMC as part of the normal OP-TEE test procedure [2]. For more details on how to get, build and test the SPMC, please see [3]. Our 3.19 release related test results are captured on this page [4]. Regards, Balint [1] https://optee.readthedocs.io/en/latest/architecture/spmc.html#sp-loading-me… [2] https://github.com/OP-TEE/optee_test/blob/3.19.0/host/xtest/ffa_spmc_1000.c [3] https://developer.trustedfirmware.org/w/trusted-services/op-tee-spmc [4] https://developer.trustedfirmware.org/w/trusted-services/op-tee-spmc/releas…

3 years, 12 months

1
0
0 0

OP-TEE 3.19.0 has been released

by Jérôme Forissier

Hi, I'm pleased to announce that OP-TEE version 3.19.0 is now available. As usual, the list of changes can be found in the changelog [1]. A blog post will be published soon on trustedfirmware.org [3]. A big thank you to everyone who participated with contributions and helping out with testing the release [2]. [1] https://github.com/OP-TEE/optee_os/blob/master/CHANGELOG.md [2] https://github.com/OP-TEE/optee_os/commit/afacf356f9593a7f83cae9f96026824ec… [3] https://www.trustedfirmware.org/blog/ Regards, -- Jerome

4 years

1
0
0 0

[PATCH] optee: Add __init/__exit annotations to module init/exit funcs

by Xiu Jianfeng

Add missing __init/__exit annotations to module init/exit funcs. Signed-off-by: Xiu Jianfeng <xiujianfeng(a)huawei.com> --- drivers/tee/optee/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index daf07737c4fd..2a258bd3b6b5 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -188,7 +188,7 @@ void optee_remove_common(struct optee *optee) static int smc_abi_rc; static int ffa_abi_rc; -static int optee_core_init(void) +static int __init optee_core_init(void) { /* * The kernel may have crashed at the same time that all available @@ -210,7 +210,7 @@ static int optee_core_init(void) } module_init(optee_core_init); -static void optee_core_exit(void) +static void __exit optee_core_exit(void) { if (!smc_abi_rc) optee_smc_abi_unregister(); -- 2.17.1

4 years

3
2
0 0

Preparing for OP-TEE 3.19.0

by Jérôme Forissier

[BCC all OP-TEE maintainers] Hi OP-TEE maintainers & contributors, OP-TEE v3.19.0 is scheduled to be released on 2022-10-14. So, now is a good time to start testing the master branch on the various platforms and report/fix any bugs. The GitHub pull request for collecting Tested-by tags or any other comments is https://github.com/OP-TEE/optee_os/pull/5550 As usual, we will create a release candidate tag one week before the release date for final testing. In addition to that you can find some additional information related to releases here: https://optee.readthedocs.io/en/latest/general/releases.html Thanks, -- Jerome

4 years

1
1
0 0

Linaro OP-TEE Contributions (LOC) monthly meeting

by Jens Wiklander

Hi, We don't have any topics for the meeting today, so let's cancel it. The time slot we've allocated for this meeting is either bad or worse for me so I'd like to try and find a new time slot. Please use the doodle link [1] below to record your preferences. The doodle poll is public so feel free to email me directly instead in case you're more comfortable with that. This is my first time creating a doodle poll, so apologies if I've made a mess of it. As noted in the poll we're looking for a day and time in the fourth week of the month. We're using the CET time zone as many of us are in the time zone. If you can't find any time that works for you please send me a mail with more suitable times and I'll try to work out something. Let's give this a week or so to possibly settle on a new time slot. [1] https://doodle.com/meeting/participate/id/dJqR4Eyb Thanks, Jens

4 years

1
2
0 0

2026

2025

2024

2023

2022

2021

2020

OP-TEE