On Fri, Mar 27, 2026 at 05:40:16PM +0530, Harshal Dev wrote:
On 3/12/2026 11:57 AM, Sumit Garg wrote:
From: Sumit Garg sumit.garg@oss.qualcomm.com
With the availability of generic PAS service, let's add SCM calls as a backend to keep supporting legacy QTEE interfaces. The exported qcom_scm* wrappers will get dropped once all the client drivers get migrated as part of future patches.
Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com
drivers/firmware/qcom/Kconfig | 1 + drivers/firmware/qcom/qcom_scm.c | 336 ++++++++++++++----------------- 2 files changed, 156 insertions(+), 181 deletions(-)
[..]
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 8fbc96693a55..2d7937ae7c8f 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -13,6 +13,7 @@ #include <linux/dma-mapping.h>
[..]
-/**
- devm_qcom_scm_pas_context_alloc() - Allocate peripheral authentication service
context for a given peripheral
- PAS context is device-resource managed, so the caller does not need
- to worry about freeing the context memory.
- @dev: PAS firmware device
- @pas_id: peripheral authentication service id
- @mem_phys: Subsystem reserve memory start address
- @mem_size: Subsystem reserve memory size
- Returns: The new PAS context, or ERR_PTR() on failure.
- */
Shouldn't we drop the documentation for the exported functions in this file as part of patch 14/15? After this patch is applied, the devm_qcom_scm_pas_context_alloc() function still remains exported and available.
I don't see value in maintaining redundant documentation during the course of the patch-set. The wrappers are only maintained to keep the individual commits compilable such that we don't break kernel git bisection scripts.
-Sumit