On Mon, Dec 8, 2025 at 10:14 PM Dmitry Baryshkov dmitry.baryshkov@oss.qualcomm.com wrote:
On Tue, 9 Dec 2025 at 07:58, Krzysztof Kozlowski krzk@kernel.org wrote:
On 08/12/2025 13:18, Harshal Dev wrote:
Enable QCOMTEE driver on Qualcomm SM8650+ SoCs to facilitate communication with the Qualcomm Trusted Execution Environment (QTEE). (No enablement required in DTS files since QCOMTEE device is dynamically registered by the QCOM_SCM firmware driver)
Signed-off-by: Harshal Dev harshal.dev@oss.qualcomm.com
Changes in v3:
- Updated the commit message to reflect the supported Qualcomm platforms.
- Link to v2: https://lore.kernel.org/r/20251205-qcom_qcomtee_defconfig-v2-1-c92560b0346e@...
I gave you the exact example to follow. Maybe it is not that important for others, so I will not object, but OTOH it is important for me, thus I will not give reviewed by. I damn asked VERY CLEARLY:
"Just mention which UPSTREAM boards (which you called Qualcomm platforms) use this driver."
+1 Here. Defconfig changes mention devices, not SoC families.
I don't agree that you have to mention a specific board, if the feature is used by all boards. But I think the commit message should make _that_ clear.
On the contrary, the commit message says that we're enabling CONFIG_QCOMTEE because it's used on "SM8560+". What does the plus mean? Also, the driver isn't enabled "on Qualcomm SM8650+", it's enabled in the Am64 defconfig, i.e. it's enabled on all Arm64 boards - the question that should be answered by the commit message is "why?".
PS. When you then run "git log arch/arm64/config/defconfig", the information that enabling QCOMTEE doesn't require DeviceTree changes is not useful.
Regards, Bjorn
Usage of something on SoC is not a proof that it actually is used by upstream platforms and we absolutely do not care at all about downstream users. I spent way too much time on this and even very specific instructions were not working, so I don't know how else I can help.
Best regards, Krzysztof
-- With best wishes Dmitry