On 10/12/2025 04:51, Bjorn Andersson wrote:
On Mon, Dec 8, 2025 at 10:14 PM Dmitry Baryshkov dmitry.baryshkov@oss.qualcomm.com wrote:
On Tue, 9 Dec 2025 at 07:58, Krzysztof Kozlowski krzk@kernel.org wrote:
On 08/12/2025 13:18, Harshal Dev wrote:
Enable QCOMTEE driver on Qualcomm SM8650+ SoCs to facilitate communication with the Qualcomm Trusted Execution Environment (QTEE). (No enablement required in DTS files since QCOMTEE device is dynamically registered by the QCOM_SCM firmware driver)
Signed-off-by: Harshal Dev harshal.dev@oss.qualcomm.com
Changes in v3:
- Updated the commit message to reflect the supported Qualcomm platforms.
- Link to v2: https://lore.kernel.org/r/20251205-qcom_qcomtee_defconfig-v2-1-c92560b0346e@...
I gave you the exact example to follow. Maybe it is not that important for others, so I will not object, but OTOH it is important for me, thus I will not give reviewed by. I damn asked VERY CLEARLY:
"Just mention which UPSTREAM boards (which you called Qualcomm platforms) use this driver."
+1 Here. Defconfig changes mention devices, not SoC families.
I don't agree that you have to mention a specific board, if the feature is used by all boards. But I think the commit message should make _that_ clear.
Yes, that would be enough and I would be fine with it as well, but I did not have that impression from the commit msg.
Best regards, Krzysztof