On Mon, Apr 27, 2026 at 03:25:50PM +0530, Sumit Garg wrote:

From: Sumit Garg sumit.garg@oss.qualcomm.com

Qcom platforms has the legacy of using non-standard SCM calls splintered over the various kernel drivers. These SCM calls aren't compliant with the standard SMC calling conventions which is a prerequisite to enable migration to the FF-A specifications from Arm.

OP-TEE as an alternative trusted OS to Qualcomm TEE (QTEE) can't support these non-standard SCM calls. And even for newer architectures using S-EL2 with Hafnium support, QTEE won't be able to support SCM calls either with FF-A requirements coming in. And with both OP-TEE and QTEE drivers well integrated in the TEE subsystem, it makes further sense to reuse the TEE bus client drivers infrastructure.

The added benefit of TEE bus infrastructure is that there is support for discoverable/enumerable services. With that client drivers don't have to manually invoke a special SCM call to know the service status.

So enable the generic Peripheral Authentication Service (PAS) provided by the firmware. It acts as the common layer with different TZ backends plugged in whether it's an SCM implementation or a proper TEE bus based PAS service implementation.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/firmware/qcom/Kconfig | 8 + drivers/firmware/qcom/Makefile | 1 + drivers/firmware/qcom/qcom_pas.c | 288 +++++++++++++++++++++++++ drivers/firmware/qcom/qcom_pas.h | 50 +++++ include/linux/firmware/qcom/qcom_pas.h | 43 ++++ 5 files changed, 390 insertions(+) create mode 100644 drivers/firmware/qcom/qcom_pas.c create mode 100644 drivers/firmware/qcom/qcom_pas.h create mode 100644 include/linux/firmware/qcom/qcom_pas.h

diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig index b477d54b495a..8653639d06db 100644 --- a/drivers/firmware/qcom/Kconfig +++ b/drivers/firmware/qcom/Kconfig @@ -6,6 +6,14 @@ menu "Qualcomm firmware drivers" +config QCOM_PAS

• tristate
• help

•  Enable the generic Peripheral Authentication Service (PAS) provided
  

•  by the firmware. It acts as the common layer with different TZ
  

•  backends plugged in whether it's an SCM implementation or a proper
  

•  TEE bus based PAS service implementation.
  

config QCOM_SCM select QCOM_TZMEM tristate diff --git a/drivers/firmware/qcom/Makefile b/drivers/firmware/qcom/Makefile index 0be40a1abc13..dc5ab45f906a 100644 --- a/drivers/firmware/qcom/Makefile +++ b/drivers/firmware/qcom/Makefile @@ -8,3 +8,4 @@ qcom-scm-objs += qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o obj-$(CONFIG_QCOM_TZMEM) += qcom_tzmem.o obj-$(CONFIG_QCOM_QSEECOM) += qcom_qseecom.o obj-$(CONFIG_QCOM_QSEECOM_UEFISECAPP) += qcom_qseecom_uefisecapp.o +obj-$(CONFIG_QCOM_PAS) += qcom_pas.o diff --git a/drivers/firmware/qcom/qcom_pas.c b/drivers/firmware/qcom/qcom_pas.c new file mode 100644 index 000000000000..caf7fff33e5c --- /dev/null +++ b/drivers/firmware/qcom/qcom_pas.c @@ -0,0 +1,288 @@ +// SPDX-License-Identifier: GPL-2.0 +/*

• • Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
• */

+#include <linux/device/devres.h> +#include <linux/firmware/qcom/qcom_pas.h> +#include <linux/kernel.h> +#include <linux/module.h>

+#include "qcom_pas.h"

+static struct qcom_pas_ops *ops_ptr;

+/**

• • devm_qcom_pas_context_alloc() - Allocate peripheral authentication service

• • 		   context for a given peripheral
    

• • PAS context is device-resource managed, so the caller does not need
• • to worry about freeing the context memory.
• • @dev: PAS firmware device
• • @pas_id: peripheral authentication service id
• • @mem_phys: Subsystem reserve memory start address
• • @mem_size: Subsystem reserve memory size
• • Return: The new PAS context, or ERR_PTR() on failure.
• */

+struct qcom_pas_context *devm_qcom_pas_context_alloc(struct device *dev,

• 				     u32 pas_id,
  

• 				     phys_addr_t mem_phys,
  

• 				     size_t mem_size)
  

+{

• struct qcom_pas_context *ctx;
• ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
• if (!ctx)

• return ERR_PTR(-ENOMEM);
  

• ctx->dev = dev;
• ctx->pas_id = pas_id;
• ctx->mem_phys = mem_phys;
• ctx->mem_size = mem_size;
• return ctx;

+} +EXPORT_SYMBOL_GPL(devm_qcom_pas_context_alloc);

+/**

• • qcom_pas_init_image() - Initialize peripheral authentication service state

• • 	   machine for a given peripheral, using the metadata
    

• • @pas_id: peripheral authentication service id
• • @metadata: pointer to memory containing ELF header, program header table

• • and optional blob of data used for authenticating the metadata
    

• • and the rest of the firmware
    

• • @size: size of the metadata
• • @ctx: optional pas context
• • Return: 0 on success.
• • Upon successful return, the PAS metadata context (@ctx) will be used to
• • track the metadata allocation, this needs to be released by invoking
• • qcom_pas_metadata_release() by the caller.
• */

+int qcom_pas_init_image(u32 pas_id, const void *metadata, size_t size,

• 	struct qcom_pas_context *ctx)
  

+{

• if (!ops_ptr)

• return -ENODEV;
  

• return ops_ptr->init_image(ops_ptr->dev, pas_id, metadata, size, ctx);

+} +EXPORT_SYMBOL_GPL(qcom_pas_init_image);

+/**

• • qcom_pas_metadata_release() - release metadata context
• • @ctx: pas context
• */

+void qcom_pas_metadata_release(struct qcom_pas_context *ctx) +{

• if (!ctx || !ctx->ptr || !ops_ptr)

reverse order..

• return;
  

• ops_ptr->metadata_release(ops_ptr->dev, ctx);

+} +EXPORT_SYMBOL_GPL(qcom_pas_metadata_release);

+/**

• • qcom_pas_mem_setup() - Prepare the memory related to a given peripheral

• • 	  for firmware loading
    

• • @pas_id: peripheral authentication service id
• • @addr: start address of memory area to prepare
• • @size: size of the memory area to prepare
• • Return: 0 on success.
• */

+int qcom_pas_mem_setup(u32 pas_id, phys_addr_t addr, phys_addr_t size) +{

• if (!ops_ptr)

• return -ENODEV;
  

• return ops_ptr->mem_setup(ops_ptr->dev, pas_id, addr, size);

+} +EXPORT_SYMBOL_GPL(qcom_pas_mem_setup);

+/**

• • qcom_pas_get_rsc_table() - Retrieve the resource table in passed output buffer

• • 	      for a given peripheral.
    

• • Qualcomm remote processor may rely on both static and dynamic resources for
• • its functionality. Static resources typically refer to memory-mapped
• • addresses required by the subsystem and are often embedded within the
• • firmware binary and dynamic resources, such as shared memory in DDR etc.,
• • are determined at runtime during the boot process.
• • On Qualcomm Technologies devices, it's possible that static resources are
• • not embedded in the firmware binary and instead are provided by TrustZone.
• • However, dynamic resources are always expected to come from TrustZone. This
• • indicates that for Qualcomm devices, all resources (static and dynamic) will
• • be provided by TrustZone PAS service.
• • If the remote processor firmware binary does contain static resources, they
• • should be passed in input_rt. These will be forwarded to TrustZone for
• • authentication. TrustZone will then append the dynamic resources and return
• • the complete resource table in output_rt_tzm.
• • If the remote processor firmware binary does not include a resource table,
• • the caller of this function should set input_rt as NULL and input_rt_size
• • as zero respectively.
• • More about documentation on resource table data structures can be found in
• • include/linux/remoteproc.h
• • @ctx: PAS context
• • @pas_id: peripheral authentication service id
• • @input_rt: resource table buffer which is present in firmware binary
• • @input_rt_size: size of the resource table present in firmware binary
• • @output_rt_size: TrustZone expects caller should pass worst case size for

• •     the output_rt_tzm.
    

• • Return:
• • On success, returns a pointer to the allocated buffer containing the final
• • resource table and output_rt_size will have actual resource table size from
• • TrustZone. The caller is responsible for freeing the buffer. On failure,
• • returns ERR_PTR(-errno).
• */

+struct resource_table *qcom_pas_get_rsc_table(struct qcom_pas_context *ctx,

• 			      void *input_rt,
  

• 			      size_t input_rt_size,
  

• 			      size_t *output_rt_size)
  

+{

• if (!ctx)

• return ERR_PTR(-EINVAL);
  

• if (!ops_ptr)

• return ERR_PTR(-ENODEV);
  

same as below

• return ops_ptr->get_rsc_table(ops_ptr->dev, ctx, input_rt,

• 		      input_rt_size, output_rt_size);
  

+} +EXPORT_SYMBOL_GPL(qcom_pas_get_rsc_table);

+/**

• • qcom_pas_auth_and_reset() - Authenticate the given peripheral firmware

• • 	       and reset the remote processor
    

• • @pas_id: peripheral authentication service id
• • Return: 0 on success.
• */

+int qcom_pas_auth_and_reset(u32 pas_id) +{

• if (!ops_ptr)

• return -ENODEV;
  

• return ops_ptr->auth_and_reset(ops_ptr->dev, pas_id);

+} +EXPORT_SYMBOL_GPL(qcom_pas_auth_and_reset);

+/**

• • qcom_pas_prepare_and_auth_reset() - Prepare, authenticate, and reset the

• • 		       remote processor
    

• • @ctx: Context saved during call to qcom_scm_pas_context_init()
• • This function performs the necessary steps to prepare a PAS subsystem,
• • authenticate it using the provided metadata, and initiate a reset sequence.
• • It should be used when Linux is in control setting up the IOMMU hardware
• • for remote subsystem during secure firmware loading processes. The
• • preparation step sets up a shmbridge over the firmware memory before
• • TrustZone accesses the firmware memory region for authentication. The
• • authentication step verifies the integrity and authenticity of the firmware
• • or configuration using secure metadata. Finally, the reset step ensures the
• • subsystem starts in a clean and sane state.
• • Return: 0 on success, negative errno on failure.
• */

+int qcom_pas_prepare_and_auth_reset(struct qcom_pas_context *ctx) +{

• if (!ctx)

• return -EINVAL;
  

• if (!ops_ptr)

• return -ENODEV;
  

They should be checked in reverse order, no point in checking ctx if ops_ptr is NULL .,

• return ops_ptr->prepare_and_auth_reset(ops_ptr->dev, ctx);

+} +EXPORT_SYMBOL_GPL(qcom_pas_prepare_and_auth_reset);

+/**

• • qcom_pas_set_remote_state() - Set the remote processor state
• • @state: peripheral state
• • @pas_id: peripheral authentication service id
• • Return: 0 on success.
• */

+int qcom_pas_set_remote_state(u32 state, u32 pas_id) +{

• if (!ops_ptr)

• return -ENODEV;
  

• return ops_ptr->set_remote_state(ops_ptr->dev, state, pas_id);

+} +EXPORT_SYMBOL_GPL(qcom_pas_set_remote_state);

+/**

• • qcom_pas_shutdown() - Shut down the remote processor
• • @pas_id: peripheral authentication service id
• • Return: 0 on success.
• */

+int qcom_pas_shutdown(u32 pas_id) +{

• if (!ops_ptr)

• return -ENODEV;
  

• return ops_ptr->shutdown(ops_ptr->dev, pas_id);

+} +EXPORT_SYMBOL_GPL(qcom_pas_shutdown);

+/**

• • qcom_pas_supported() - Check if the peripheral authentication service is

• • 	  available for the given peripheral
    

• • @pas_id: peripheral authentication service id
• • Return: true if PAS is supported for this peripheral, otherwise false.
• */

+bool qcom_pas_supported(u32 pas_id) +{

• if (!ops_ptr)

• return false;
  

• return ops_ptr->supported(ops_ptr->dev, pas_id);

+} +EXPORT_SYMBOL_GPL(qcom_pas_supported);

+bool qcom_pas_is_available(void) +{

• /*

• * The barrier for ops_ptr is intended to synchronize the data stores
  

• * for the ops data structure when client drivers are in parallel
  

• * checking for PAS service availability.
  

• *
  

• * Once the PAS backend becomes available, it is allowed for multiple
  

• * threads to enter TZ for parallel bringup of co-processors during
  

• * boot.
  

• */
  

• return !!smp_load_acquire(&ops_ptr);

+} +EXPORT_SYMBOL_GPL(qcom_pas_is_available);

+void qcom_pas_ops_register(struct qcom_pas_ops *ops) +{

• if (!qcom_pas_is_available())

• /* Paired with smp_load_acquire() in qcom_pas_is_available() */
  

• smp_store_release(&ops_ptr, ops);
  

• else

• pr_err("qcom_pas: ops already registered\n");
  

pr_err("qcom_pas: ops already registered by %s\n", ops_ptr->drv_name);

+} +EXPORT_SYMBOL_GPL(qcom_pas_ops_register);

+void qcom_pas_ops_unregister(void) +{

• /* Paired with smp_load_acquire() in qcom_pas_is_available() */
• smp_store_release(&ops_ptr, NULL);

+} +EXPORT_SYMBOL_GPL(qcom_pas_ops_unregister);

+MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Qualcomm common TZ PAS driver");

generic ??

diff --git a/drivers/firmware/qcom/qcom_pas.h b/drivers/firmware/qcom/qcom_pas.h new file mode 100644 index 000000000000..8643e2760602 --- /dev/null +++ b/drivers/firmware/qcom/qcom_pas.h @@ -0,0 +1,50 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/*

• • Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
• */

+#ifndef __QCOM_PAS_INT_H +#define __QCOM_PAS_INT_H

+struct device;

+/**

• • struct qcom_pas_ops - Qcom Peripheral Authentication Service (PAS) ops
• • @drv_name: PAS driver name.
• • @dev: PAS device pointer.
• • @supported: Peripheral supported callback.
• • @init_image: Peripheral image initialization callback.
• • @mem_setup: Peripheral memory setup callback.
• • @get_rsc_table: Peripheral get resource table callback.
• • @prepare_and_auth_reset: Peripheral prepare firmware authentication and

• • 		reset callback.
    

• • @auth_and_reset: Peripheral firmware authentication and reset

• • 		callback.
    

• • @set_remote_state: Peripheral set remote state callback.
• • @shutdown: Peripheral shutdown callback.
• • @metadata_release: Image metadata release callback.
• */

+struct qcom_pas_ops {

• const char *drv_name;
• struct device *dev;
• bool (*supported)(struct device *dev, u32 pas_id);
• int (*init_image)(struct device *dev, u32 pas_id, const void *metadata,

• 	  size_t size, struct qcom_pas_context *ctx);
  

• int (*mem_setup)(struct device *dev, u32 pas_id, phys_addr_t addr,

• 	 phys_addr_t size);
  

• void *(*get_rsc_table)(struct device *dev, struct qcom_pas_context *ctx,

• 	       void *input_rt, size_t input_rt_size,
  

• 	       size_t *output_rt_size);
  

• int (*prepare_and_auth_reset)(struct device *dev,

• 		      struct qcom_pas_context *ctx);
  

• int (*auth_and_reset)(struct device *dev, u32 pas_id);
• int (*set_remote_state)(struct device *dev, u32 state, u32 pas_id);
• int (*shutdown)(struct device *dev, u32 pas_id);
• void (*metadata_release)(struct device *dev,

• 		 struct qcom_pas_context *ctx);
  

+};

+void qcom_pas_ops_register(struct qcom_pas_ops *ops); +void qcom_pas_ops_unregister(void);

+#endif /* __QCOM_PAS_INT_H */ diff --git a/include/linux/firmware/qcom/qcom_pas.h b/include/linux/firmware/qcom/qcom_pas.h new file mode 100644 index 000000000000..65b1c9564458 --- /dev/null +++ b/include/linux/firmware/qcom/qcom_pas.h @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/*

• • Copyright (c) 2010-2015, 2018-2019 The Linux Foundation. All rights reserved.
• • Copyright (C) 2015 Linaro Ltd.
• • Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
• */

Here, you kept the copyright but not in the C file.., from my view, both qcom_pas.c and qcom_pas.h are derivative work(>50%) and should carry the original license while drivers/firmware/qcom/qcom_pas.h is new work...

+#ifndef __QCOM_PAS_H +#define __QCOM_PAS_H

+#include <linux/err.h> +#include <linux/types.h>

+struct qcom_pas_context {

• struct device *dev;
• u32 pas_id;
• phys_addr_t mem_phys;
• size_t mem_size;
• void *ptr;
• dma_addr_t phys;
• ssize_t size;
• bool use_tzmem;

+};

+bool qcom_pas_is_available(void); +struct qcom_pas_context *devm_qcom_pas_context_alloc(struct device *dev,

• 				     u32 pas_id,
  

• 				     phys_addr_t mem_phys,
  

• 				     size_t mem_size);
  

+int qcom_pas_init_image(u32 pas_id, const void *metadata, size_t size,

• 	struct qcom_pas_context *ctx);
  

+struct resource_table *qcom_pas_get_rsc_table(struct qcom_pas_context *ctx,

• 			      void *input_rt, size_t input_rt_size,
  

• 			      size_t *output_rt_size);
  

+int qcom_pas_mem_setup(u32 pas_id, phys_addr_t addr, phys_addr_t size); +int qcom_pas_auth_and_reset(u32 pas_id); +int qcom_pas_prepare_and_auth_reset(struct qcom_pas_context *ctx); +int qcom_pas_set_remote_state(u32 state, u32 pas_id); +int qcom_pas_shutdown(u32 pas_id); +bool qcom_pas_supported(u32 pas_id); +void qcom_pas_metadata_release(struct qcom_pas_context *ctx);

+#endif /* __QCOM_PAS_H */

2.51.0

With above change,

Reviewed-by: Mukesh Ojha mukesh.ojha@oss.qualcomm.com

On Mon, Apr 27, 2026 at 03:25:51PM +0530, Sumit Garg wrote:

From: Sumit Garg sumit.garg@oss.qualcomm.com

With the availability of generic PAS service, let's add SCM calls as a backend to keep supporting legacy QTEE interfaces. The exported qcom_scm* wrappers will get dropped once all the client drivers get migrated as part of future patches.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/firmware/qcom/Kconfig | 1 + drivers/firmware/qcom/qcom_scm.c | 335 ++++++++++++++----------------- 2 files changed, 155 insertions(+), 181 deletions(-)

diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig index 8653639d06db..9a12ae2b639d 100644 --- a/drivers/firmware/qcom/Kconfig +++ b/drivers/firmware/qcom/Kconfig @@ -15,6 +15,7 @@ config QCOM_PAS TEE bus based PAS service implementation. config QCOM_SCM

• select QCOM_PAS select QCOM_TZMEM tristate

diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 9b06a69d3a6d..d87a962e93da 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -13,6 +13,7 @@ #include <linux/dma-mapping.h> #include <linux/err.h> #include <linux/export.h> +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/firmware/qcom/qcom_scm.h> #include <linux/firmware/qcom/qcom_tzmem.h> #include <linux/init.h> @@ -33,6 +34,7 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> +#include "qcom_pas.h" #include "qcom_scm.h" #include "qcom_tzmem.h" @@ -479,25 +481,6 @@ void qcom_scm_cpu_power_down(u32 flags) } EXPORT_SYMBOL_GPL(qcom_scm_cpu_power_down); -int qcom_scm_set_remote_state(u32 state, u32 id) -{

• struct qcom_scm_desc desc = {

• .svc = QCOM_SCM_SVC_BOOT,
  

• .cmd = QCOM_SCM_BOOT_SET_REMOTE_STATE,
  

• .arginfo = QCOM_SCM_ARGS(2),
  

• .args[0] = state,
  

• .args[1] = id,
  

• .owner = ARM_SMCCC_OWNER_SIP,
  

• };
• struct qcom_scm_res res;
• int ret;
• ret = qcom_scm_call(__scm->dev, &desc, &res);
• return ret ? : res.result[0];

-} -EXPORT_SYMBOL_GPL(qcom_scm_set_remote_state);

static int qcom_scm_disable_sdi(void) { int ret; @@ -570,26 +553,12 @@ static void qcom_scm_set_download_mode(u32 dload_mode) dev_err(__scm->dev, "failed to set download mode: %d\n", ret); } -/**

• • devm_qcom_scm_pas_context_alloc() - Allocate peripheral authentication service

• • 		       context for a given peripheral
    

• • PAS context is device-resource managed, so the caller does not need
• • to worry about freeing the context memory.
• • @dev: PAS firmware device
• • @pas_id: peripheral authentication service id
• • @mem_phys: Subsystem reserve memory start address
• • @mem_size: Subsystem reserve memory size
• • Returns: The new PAS context, or ERR_PTR() on failure.
• */

struct qcom_scm_pas_context *devm_qcom_scm_pas_context_alloc(struct device *dev, u32 pas_id, phys_addr_t mem_phys, size_t mem_size) {

• struct qcom_scm_pas_context *ctx;

• struct qcom_pas_context *ctx;

ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); if (!ctx) @@ -600,11 +569,12 @@ struct qcom_scm_pas_context *devm_qcom_scm_pas_context_alloc(struct device *dev, ctx->mem_phys = mem_phys; ctx->mem_size = mem_size;

• return ctx;

• return (struct qcom_scm_pas_context *)ctx;

} EXPORT_SYMBOL_GPL(devm_qcom_scm_pas_context_alloc); -static int __qcom_scm_pas_init_image(u32 pas_id, dma_addr_t mdata_phys, +static int __qcom_scm_pas_init_image(struct device *dev, u32 pas_id,

• 		     dma_addr_t mdata_phys,
  	     struct qcom_scm_res *res)
  

{ struct qcom_scm_desc desc = { @@ -626,7 +596,7 @@ static int __qcom_scm_pas_init_image(u32 pas_id, dma_addr_t mdata_phys, desc.args[1] = mdata_phys;

• ret = qcom_scm_call(__scm->dev, &desc, res);

• ret = qcom_scm_call(dev, &desc, res); qcom_scm_bw_disable();

disable_clk: @@ -635,7 +605,8 @@ static int __qcom_scm_pas_init_image(u32 pas_id, dma_addr_t mdata_phys, return ret; } -static int qcom_scm_pas_prep_and_init_image(struct qcom_scm_pas_context *ctx, +static int qcom_scm_pas_prep_and_init_image(struct device *dev,

• 			    struct qcom_pas_context *ctx,
  		    const void *metadata, size_t size)
  

{ struct qcom_scm_res res; @@ -650,7 +621,7 @@ static int qcom_scm_pas_prep_and_init_image(struct qcom_scm_pas_context *ctx, memcpy(mdata_buf, metadata, size); mdata_phys = qcom_tzmem_to_phys(mdata_buf);

• ret = __qcom_scm_pas_init_image(ctx->pas_id, mdata_phys, &res);

• ret = __qcom_scm_pas_init_image(dev, ctx->pas_id, mdata_phys, &res); if (ret < 0) qcom_tzmem_free(mdata_buf); else

@@ -659,25 +630,9 @@ static int qcom_scm_pas_prep_and_init_image(struct qcom_scm_pas_context *ctx, return ret ? : res.result[0]; } -/**

• • qcom_scm_pas_init_image() - Initialize peripheral authentication service

• • 	       state machine for a given peripheral, using the
    

• • 	       metadata
    

• • @pas_id: peripheral authentication service id
• • @metadata: pointer to memory containing ELF header, program header table

• • and optional blob of data used for authenticating the metadata
    

• • and the rest of the firmware
    

• • @size: size of the metadata
• • @ctx: optional pas context
• • Return: 0 on success.
• • Upon successful return, the PAS metadata context (@ctx) will be used to
• • track the metadata allocation, this needs to be released by invoking
• • qcom_scm_pas_metadata_release() by the caller.
• */

-int qcom_scm_pas_init_image(u32 pas_id, const void *metadata, size_t size,

• 	    struct qcom_scm_pas_context *ctx)
  

+static int __qcom_scm_pas_init_image2(struct device *dev, u32 pas_id,

• 		      const void *metadata, size_t size,
  

• 		      struct qcom_pas_context *ctx)
  

{ struct qcom_scm_res res; dma_addr_t mdata_phys; @@ -685,7 +640,7 @@ int qcom_scm_pas_init_image(u32 pas_id, const void *metadata, size_t size, int ret; if (ctx && ctx->use_tzmem)

• return qcom_scm_pas_prep_and_init_image(ctx, metadata, size);
  

• return qcom_scm_pas_prep_and_init_image(dev, ctx, metadata, size);
  

/* * During the scm call memory protection will be enabled for the meta @@ -699,16 +654,15 @@ int qcom_scm_pas_init_image(u32 pas_id, const void *metadata, size_t size, * If we pass a buffer that is already part of an SHM Bridge to this * call, it will fail. */

• mdata_buf = dma_alloc_coherent(__scm->dev, size, &mdata_phys,

• 		       GFP_KERNEL);
  

• mdata_buf = dma_alloc_coherent(dev, size, &mdata_phys, GFP_KERNEL); if (!mdata_buf) return -ENOMEM;

memcpy(mdata_buf, metadata, size);

• ret = __qcom_scm_pas_init_image(pas_id, mdata_phys, &res);

• ret = __qcom_scm_pas_init_image(dev, pas_id, mdata_phys, &res); if (ret < 0 || !ctx) {

• dma_free_coherent(__scm->dev, size, mdata_buf, mdata_phys);
  

• dma_free_coherent(dev, size, mdata_buf, mdata_phys);
  

  } else if (ctx) { ctx->ptr = mdata_buf; ctx->phys = mdata_phys;

@@ -717,36 +671,35 @@ int qcom_scm_pas_init_image(u32 pas_id, const void *metadata, size_t size, return ret ? : res.result[0]; } -EXPORT_SYMBOL_GPL(qcom_scm_pas_init_image); -/**

• • qcom_scm_pas_metadata_release() - release metadata context
• • @ctx: pas context
• */

-void qcom_scm_pas_metadata_release(struct qcom_scm_pas_context *ctx) +int qcom_scm_pas_init_image(u32 pas_id, const void *metadata, size_t size,

• 	    struct qcom_scm_pas_context *ctx)
  

{

• if (!ctx->ptr)

• return;
  

• return __qcom_scm_pas_init_image2(__scm->dev, pas_id, metadata, size,

• 			  (struct qcom_pas_context *)ctx);
  

+} +EXPORT_SYMBOL_GPL(qcom_scm_pas_init_image); +static void __qcom_scm_pas_metadata_release(struct device *dev,

• 			    struct qcom_pas_context *ctx)
  

+{ if (ctx->use_tzmem) qcom_tzmem_free(ctx->ptr); else

• dma_free_coherent(__scm->dev, ctx->size, ctx->ptr, ctx->phys);
  

• dma_free_coherent(dev, ctx->size, ctx->ptr, ctx->phys);
  

ctx->ptr = NULL; }

+void qcom_scm_pas_metadata_release(struct qcom_scm_pas_context *ctx) +{

• __qcom_scm_pas_metadata_release(__scm->dev,

• 			(struct qcom_pas_context *)ctx);
  

+} EXPORT_SYMBOL_GPL(qcom_scm_pas_metadata_release); -/**

• • qcom_scm_pas_mem_setup() - Prepare the memory related to a given peripheral

• • 	      for firmware loading
    

• • @pas_id: peripheral authentication service id
• • @addr: start address of memory area to prepare
• • @size: size of the memory area to prepare
• • Returns 0 on success.
• */

-int qcom_scm_pas_mem_setup(u32 pas_id, phys_addr_t addr, phys_addr_t size) +static int __qcom_scm_pas_mem_setup(struct device *dev, u32 pas_id,

• 		    phys_addr_t addr, phys_addr_t size)
  

{ int ret; struct qcom_scm_desc desc = { @@ -768,7 +721,7 @@ int qcom_scm_pas_mem_setup(u32 pas_id, phys_addr_t addr, phys_addr_t size) if (ret) goto disable_clk;

• ret = qcom_scm_call(__scm->dev, &desc, &res);

• ret = qcom_scm_call(dev, &desc, &res); qcom_scm_bw_disable();

disable_clk: @@ -776,9 +729,15 @@ int qcom_scm_pas_mem_setup(u32 pas_id, phys_addr_t addr, phys_addr_t size) return ret ? : res.result[0]; }

+int qcom_scm_pas_mem_setup(u32 pas_id, phys_addr_t addr, phys_addr_t size) +{

• return __qcom_scm_pas_mem_setup(__scm->dev, pas_id, addr, size);

+} EXPORT_SYMBOL_GPL(qcom_scm_pas_mem_setup); -static void *__qcom_scm_pas_get_rsc_table(u32 pas_id, void *input_rt_tzm, +static void *__qcom_scm_pas_get_rsc_table(struct device *dev, u32 pas_id,

• 			  void *input_rt_tzm,
  		  size_t input_rt_size,
  		  size_t *output_rt_size)
  

{ @@ -813,7 +772,7 @@ static void *__qcom_scm_pas_get_rsc_table(u32 pas_id, void *input_rt_tzm, * with output_rt_tzm buffer with res.result[2] size however, It should not * be of unresonable size. */

• ret = qcom_scm_call(__scm->dev, &desc, &res);

• ret = qcom_scm_call(dev, &desc, &res); if (!ret && res.result[2] > SZ_1G) { ret = -E2BIG; goto free_output_rt;

@@ -830,51 +789,11 @@ static void *__qcom_scm_pas_get_rsc_table(u32 pas_id, void *input_rt_tzm, return ret ? ERR_PTR(ret) : output_rt_tzm; } -/**

• • qcom_scm_pas_get_rsc_table() - Retrieve the resource table in passed output buffer

• • 		  for a given peripheral.
    

• • Qualcomm remote processor may rely on both static and dynamic resources for
• • its functionality. Static resources typically refer to memory-mapped addresses
• • required by the subsystem and are often embedded within the firmware binary
• • and dynamic resources, such as shared memory in DDR etc., are determined at
• • runtime during the boot process.
• • On Qualcomm Technologies devices, it's possible that static resources are not
• • embedded in the firmware binary and instead are provided by TrustZone However,
• • dynamic resources are always expected to come from TrustZone. This indicates
• • that for Qualcomm devices, all resources (static and dynamic) will be provided
• • by TrustZone via the SMC call.
• • If the remote processor firmware binary does contain static resources, they
• • should be passed in input_rt. These will be forwarded to TrustZone for
• • authentication. TrustZone will then append the dynamic resources and return
• • the complete resource table in output_rt_tzm.
• • If the remote processor firmware binary does not include a resource table,
• • the caller of this function should set input_rt as NULL and input_rt_size
• • as zero respectively.
• • More about documentation on resource table data structures can be found in
• • include/linux/remoteproc.h
• • @ctx: PAS context
• • @pas_id: peripheral authentication service id
• • @input_rt: resource table buffer which is present in firmware binary
• • @input_rt_size: size of the resource table present in firmware binary
• • @output_rt_size: TrustZone expects caller should pass worst case size for

• •     the output_rt_tzm.
    

• • Return:
• • On success, returns a pointer to the allocated buffer containing the final
• • resource table and output_rt_size will have actual resource table size from
• • TrustZone. The caller is responsible for freeing the buffer. On failure,
• • returns ERR_PTR(-errno).
• */

-struct resource_table *qcom_scm_pas_get_rsc_table(struct qcom_scm_pas_context *ctx,

• 				  void *input_rt,
  

• 				  size_t input_rt_size,
  

• 				  size_t *output_rt_size)
  

+static void *__qcom_scm_pas_get_rsc_table2(struct device *dev,

• 			   struct qcom_pas_context *ctx,
  

• 			   void *input_rt,
  

• 			   size_t input_rt_size,
  

• 			   size_t *output_rt_size)
  

{ struct resource_table empty_rsc = {}; size_t size = SZ_16K; @@ -909,11 +828,12 @@ struct resource_table *qcom_scm_pas_get_rsc_table(struct qcom_scm_pas_context *c memcpy(input_rt_tzm, input_rt, input_rt_size);

• output_rt_tzm = __qcom_scm_pas_get_rsc_table(ctx->pas_id, input_rt_tzm,

• output_rt_tzm = __qcom_scm_pas_get_rsc_table(dev, ctx->pas_id,

• 				     input_rt_tzm,
  			     input_rt_size, &size);
  

  if (PTR_ERR(output_rt_tzm) == -EOVERFLOW) /* Try again with the size requested by the TZ */

• output_rt_tzm = __qcom_scm_pas_get_rsc_table(ctx->pas_id,
  

• output_rt_tzm = __qcom_scm_pas_get_rsc_table(dev, ctx->pas_id,
  				     input_rt_tzm,
  				     input_rt_size,
  				     &size);
  

@@ -943,16 +863,20 @@ struct resource_table *qcom_scm_pas_get_rsc_table(struct qcom_scm_pas_context *c return ret ? ERR_PTR(ret) : tbl_ptr; }

+struct resource_table *qcom_scm_pas_get_rsc_table(struct qcom_scm_pas_context *ctx,

• 				  void *input_rt,
  

• 				  size_t input_rt_size,
  

• 				  size_t *output_rt_size)
  

+{

• return __qcom_scm_pas_get_rsc_table2(__scm->dev,

• 			     (struct qcom_pas_context *)ctx,
  

• 			     input_rt, input_rt_size,
  

• 			     output_rt_size);
  

+} EXPORT_SYMBOL_GPL(qcom_scm_pas_get_rsc_table); -/**

• • qcom_scm_pas_auth_and_reset() - Authenticate the given peripheral firmware

• • 		   and reset the remote processor
    

• • @pas_id: peripheral authentication service id
• • Return 0 on success.
• */

-int qcom_scm_pas_auth_and_reset(u32 pas_id) +static int __qcom_scm_pas_auth_and_reset(struct device *dev, u32 pas_id) { int ret; struct qcom_scm_desc desc = { @@ -972,7 +896,7 @@ int qcom_scm_pas_auth_and_reset(u32 pas_id) if (ret) goto disable_clk;

• ret = qcom_scm_call(__scm->dev, &desc, &res);

• ret = qcom_scm_call(dev, &desc, &res); qcom_scm_bw_disable();

disable_clk: @@ -980,28 +904,15 @@ int qcom_scm_pas_auth_and_reset(u32 pas_id) return ret ? : res.result[0]; }

+int qcom_scm_pas_auth_and_reset(u32 pas_id) +{

• return __qcom_scm_pas_auth_and_reset(__scm->dev, pas_id);

+} EXPORT_SYMBOL_GPL(qcom_scm_pas_auth_and_reset); -/**

• • qcom_scm_pas_prepare_and_auth_reset() - Prepare, authenticate, and reset the

• • 			   remote processor
    

• • @ctx: Context saved during call to qcom_scm_pas_context_init()
• • This function performs the necessary steps to prepare a PAS subsystem,
• • authenticate it using the provided metadata, and initiate a reset sequence.
• • It should be used when Linux is in control setting up the IOMMU hardware
• • for remote subsystem during secure firmware loading processes. The preparation
• • step sets up a shmbridge over the firmware memory before TrustZone accesses the
• • firmware memory region for authentication. The authentication step verifies
• • the integrity and authenticity of the firmware or configuration using secure
• • metadata. Finally, the reset step ensures the subsystem starts in a clean and
• • sane state.
• • Return: 0 on success, negative errno on failure.
• */

-int qcom_scm_pas_prepare_and_auth_reset(struct qcom_scm_pas_context *ctx) +static int __qcom_scm_pas_prepare_and_auth_reset(struct device *dev,

• 				 struct qcom_pas_context *ctx)
  

{ u64 handle; int ret; @@ -1012,7 +923,7 @@ int qcom_scm_pas_prepare_and_auth_reset(struct qcom_scm_pas_context *ctx) * memory region and then invokes a call to TrustZone to authenticate. */ if (!ctx->use_tzmem)

• return qcom_scm_pas_auth_and_reset(ctx->pas_id);
  

• return __qcom_scm_pas_auth_and_reset(dev, ctx->pas_id);
  

/* * When Linux runs @ EL2 Linux must create the shmbridge itself and then @@ -1022,20 +933,45 @@ int qcom_scm_pas_prepare_and_auth_reset(struct qcom_scm_pas_context *ctx) if (ret) return ret;

• ret = qcom_scm_pas_auth_and_reset(ctx->pas_id);

• ret = __qcom_scm_pas_auth_and_reset(dev, ctx->pas_id); qcom_tzmem_shm_bridge_delete(handle);

return ret; }

+int qcom_scm_pas_prepare_and_auth_reset(struct qcom_scm_pas_context *ctx) +{

• return __qcom_scm_pas_prepare_and_auth_reset(__scm->dev,

• 				     (struct qcom_pas_context *)ctx);
  

+} EXPORT_SYMBOL_GPL(qcom_scm_pas_prepare_and_auth_reset); -/**

• • qcom_scm_pas_shutdown() - Shut down the remote processor
• • @pas_id: peripheral authentication service id
• • Returns 0 on success.
• */

-int qcom_scm_pas_shutdown(u32 pas_id) +static int __qcom_scm_pas_set_remote_state(struct device *dev, u32 state,

• 			   u32 pas_id)
  

+{

• struct qcom_scm_desc desc = {

• .svc = QCOM_SCM_SVC_BOOT,
  

• .cmd = QCOM_SCM_BOOT_SET_REMOTE_STATE,
  

• .arginfo = QCOM_SCM_ARGS(2),
  

• .args[0] = state,
  

• .args[1] = pas_id,
  

• .owner = ARM_SMCCC_OWNER_SIP,
  

• };
• struct qcom_scm_res res;
• int ret;
• ret = qcom_scm_call(dev, &desc, &res);
• return ret ? : res.result[0];

+}

+int qcom_scm_set_remote_state(u32 state, u32 id)

s/id/pas_id

+{

• return __qcom_scm_pas_set_remote_state(__scm->dev, state, id);

+} +EXPORT_SYMBOL_GPL(qcom_scm_set_remote_state);

+static int __qcom_scm_pas_shutdown(struct device *dev, u32 pas_id) { int ret; struct qcom_scm_desc desc = { @@ -1055,7 +991,7 @@ int qcom_scm_pas_shutdown(u32 pas_id) if (ret) goto disable_clk;

• ret = qcom_scm_call(__scm->dev, &desc, &res);

• ret = qcom_scm_call(dev, &desc, &res); qcom_scm_bw_disable();

disable_clk: @@ -1063,16 +999,14 @@ int qcom_scm_pas_shutdown(u32 pas_id) return ret ? : res.result[0]; }

+int qcom_scm_pas_shutdown(u32 pas_id) +{

• return __qcom_scm_pas_shutdown(__scm->dev, pas_id);

+} EXPORT_SYMBOL_GPL(qcom_scm_pas_shutdown); -/**

• • qcom_scm_pas_supported() - Check if the peripheral authentication service is

• • 	      available for the given peripherial
    

• • @pas_id: peripheral authentication service id
• • Returns true if PAS is supported for this peripheral, otherwise false.
• */

-bool qcom_scm_pas_supported(u32 pas_id) +static bool __qcom_scm_pas_supported(struct device *dev, u32 pas_id) { int ret; struct qcom_scm_desc desc = { @@ -1084,16 +1018,49 @@ bool qcom_scm_pas_supported(u32 pas_id) }; struct qcom_scm_res res;

• if (!__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_PIL,

• if (!__qcom_scm_is_call_available(dev, QCOM_SCM_SVC_PIL, QCOM_SCM_PIL_PAS_IS_SUPPORTED)) return false;

• ret = qcom_scm_call(__scm->dev, &desc, &res);

• ret = qcom_scm_call(dev, &desc, &res);

return ret ? false : !!res.result[0]; }

+bool qcom_scm_pas_supported(u32 pas_id) +{

• return __qcom_scm_pas_supported(__scm->dev, pas_id);

+} EXPORT_SYMBOL_GPL(qcom_scm_pas_supported); +static struct qcom_pas_ops qcom_pas_ops_scm = {

• .drv_name = "qcom_scm",
• .supported = __qcom_scm_pas_supported,
• .init_image = __qcom_scm_pas_init_image2,
• .mem_setup = __qcom_scm_pas_mem_setup,
• .get_rsc_table = __qcom_scm_pas_get_rsc_table2,
• .auth_and_reset = __qcom_scm_pas_auth_and_reset,
• .prepare_and_auth_reset = __qcom_scm_pas_prepare_and_auth_reset,
• .set_remote_state = __qcom_scm_pas_set_remote_state,
• .shutdown = __qcom_scm_pas_shutdown,
• .metadata_release = __qcom_scm_pas_metadata_release,

+};

+/**

• • qcom_scm_is_pas_available() - Check if the peripheral authentication service

• • 		 is available via SCM or not
    

• • Returns true if PAS is available, otherwise false.
• */

+static bool qcom_scm_is_pas_available(void) +{

• if (!__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_PIL,

• 			  QCOM_SCM_PIL_PAS_AUTH_AND_RESET))
  

QCOM_SCM_PIL_PAS_IS_SUPPORTED ?

• return false;
  

• return true;

+}

static int __qcom_scm_pas_mss_reset(struct device *dev, bool reset) { struct qcom_scm_desc desc = { @@ -2836,6 +2803,11 @@ static int qcom_scm_probe(struct platform_device *pdev) __get_convention();

• if (qcom_scm_is_pas_available()) {

Use qcom_scm_pas_supported() and remove qcom_scm_is_pas_available()..

• qcom_pas_ops_scm.dev = scm->dev;
  

• qcom_pas_ops_register(&qcom_pas_ops_scm);
  

• }
• /*
  • If "download mode" is requested, from this point on warmboot
  • will cause the boot stages to enter download mode, unless

@@ -2875,6 +2847,7 @@ static void qcom_scm_shutdown(struct platform_device *pdev) { /* Clean shutdown, disable download mode to allow normal restart */ qcom_scm_set_download_mode(QCOM_DLOAD_NODUMP);

• qcom_pas_ops_unregister();

} static const struct of_device_id qcom_scm_dt_match[] = { -- 2.51.0

With above changes,

Reviewed-by: Mukesh Ojha mukesh.ojha@oss.qualcomm.com

On Wed, Apr 29, 2026 at 06:50:21PM +0530, Mukesh Ojha wrote:

On Mon, Apr 27, 2026 at 03:25:52PM +0530, Sumit Garg wrote:

...

From: Sumit Garg sumit.garg@oss.qualcomm.com

Add support for Peripheral Authentication Service (PAS) driver based on TEE bus with OP-TEE providing the backend PAS service implementation.

The TEE PAS service ABI is designed to be extensible with additional API as PTA_QCOM_PAS_CAPABILITIES. This allows to accommodate any future extensions of the PAS service needed while still maintaining backwards compatibility.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/firmware/qcom/Kconfig | 10 + drivers/firmware/qcom/Makefile | 1 + drivers/firmware/qcom/qcom_pas_tee.c | 479 +++++++++++++++++++++++++++ 3 files changed, 490 insertions(+) create mode 100644 drivers/firmware/qcom/qcom_pas_tee.c

diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig index 9a12ae2b639d..300b3a1bd178 100644 --- a/drivers/firmware/qcom/Kconfig +++ b/drivers/firmware/qcom/Kconfig @@ -14,6 +14,16 @@ config QCOM_PAS backends plugged in whether it's an SCM implementation or a proper TEE bus based PAS service implementation. +config QCOM_PAS_TEE

• tristate
• select QCOM_PAS
• depends on TEE
• depends on !CPU_BIG_ENDIAN
• default m if ARCH_QCOM
• help

•  Enable the generic Peripheral Authentication Service (PAS) provided
  

•  by the firmware TEE implementation as the backend.
  

config QCOM_SCM select QCOM_PAS select QCOM_TZMEM diff --git a/drivers/firmware/qcom/Makefile b/drivers/firmware/qcom/Makefile index dc5ab45f906a..48801d18f37b 100644 --- a/drivers/firmware/qcom/Makefile +++ b/drivers/firmware/qcom/Makefile @@ -9,3 +9,4 @@ obj-$(CONFIG_QCOM_TZMEM) += qcom_tzmem.o obj-$(CONFIG_QCOM_QSEECOM) += qcom_qseecom.o obj-$(CONFIG_QCOM_QSEECOM_UEFISECAPP) += qcom_qseecom_uefisecapp.o obj-$(CONFIG_QCOM_PAS) += qcom_pas.o +obj-$(CONFIG_QCOM_PAS_TEE) += qcom_pas_tee.o diff --git a/drivers/firmware/qcom/qcom_pas_tee.c b/drivers/firmware/qcom/qcom_pas_tee.c new file mode 100644 index 000000000000..af73d0a68525 --- /dev/null +++ b/drivers/firmware/qcom/qcom_pas_tee.c @@ -0,0 +1,479 @@ +// SPDX-License-Identifier: GPL-2.0 +/*

• • Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
• */

+#include <linux/delay.h> +#include <linux/of.h> +#include <linux/firmware/qcom/qcom_pas.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/slab.h> +#include <linux/tee_drv.h> +#include <linux/uuid.h>

+#include "qcom_pas.h"

+/*

• • Peripheral Authentication Service (PAS) supported.
• • [in] params[0].value.a: Unique 32bit remote processor identifier
• */

+#define TA_QCOM_PAS_IS_SUPPORTED 1

+/*

• • PAS capabilities.
• • [in] params[0].value.a: Unique 32bit remote processor identifier
• • [out] params[1].value.a: PAS capability flags
• */

+#define TA_QCOM_PAS_CAPABILITIES 2

+/*

• • PAS image initialization.
• • [in] params[0].value.a: Unique 32bit remote processor identifier
• • [in] params[1].memref: Loadable firmware metadata
• */

+#define TA_QCOM_PAS_INIT_IMAGE 3

+/*

• • PAS memory setup.
• • [in] params[0].value.a: Unique 32bit remote processor identifier
• • [in] params[0].value.b: Relocatable firmware size
• • [in] params[1].value.a: 32bit LSB relocatable firmware memory address
• • [in] params[1].value.b: 32bit MSB relocatable firmware memory address
• */

+#define TA_QCOM_PAS_MEM_SETUP 4

+/*

• • PAS get resource table.
• • [in] params[0].value.a: Unique 32bit remote processor identifier
• • [inout] params[1].memref: Resource table config
• */

+#define TA_QCOM_PAS_GET_RESOURCE_TABLE 5

+/*

• • PAS image authentication and co-processor reset.
• • [in] params[0].value.a: Unique 32bit remote processor identifier
• • [in] params[0].value.b: Firmware size
• • [in] params[1].value.a: 32bit LSB firmware memory address
• • [in] params[1].value.b: 32bit MSB firmware memory address
• • [in] params[2].memref: Optional fw memory space shared/lent
• */

+#define TA_QCOM_PAS_AUTH_AND_RESET 6

+/*

• • PAS co-processor set suspend/resume state.
• • [in] params[0].value.a: Unique 32bit remote processor identifier
• • [in] params[0].value.b: Co-processor state identifier
• */

+#define TA_QCOM_PAS_SET_REMOTE_STATE 7

+/*

• • PAS co-processor shutdown.
• • [in] params[0].value.a: Unique 32bit remote processor identifier
• */

+#define TA_QCOM_PAS_SHUTDOWN 8

+#define TEE_NUM_PARAMS 4

+/**

• • struct qcom_pas_tee_private - PAS service private data
• • @dev: PAS service device.
• • @ctx: TEE context handler.
• • @session_id: PAS TA session identifier.
• */

+struct qcom_pas_tee_private {

• struct device *dev;
• struct tee_context *ctx;
• u32 session_id;

+};

+static bool qcom_pas_tee_supported(struct device *dev, u32 pas_id) +{

• struct qcom_pas_tee_private *data = dev_get_drvdata(dev);
• struct tee_ioctl_invoke_arg inv_arg = {

• .func = TA_QCOM_PAS_IS_SUPPORTED,
  

• .session = data->session_id,
  

• .num_params = TEE_NUM_PARAMS
  

• };
• struct tee_param param[4] = {

• [0] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = pas_id
  

• }
  

• };
• int ret;
• ret = tee_client_invoke_func(data->ctx, &inv_arg, param);
• if (ret < 0 || inv_arg.ret != 0) {

• dev_err(dev, "PAS not supported, pas_id: %d, ret: %d, err: 0x%x\n",
  

• 	pas_id, ret, inv_arg.ret);
  

• return false;
  

• }
• return true;

+}

+static int qcom_pas_tee_init_image(struct device *dev, u32 pas_id,

• 		   const void *metadata, size_t size,
  

• 		   struct qcom_pas_context *ctx)
  

+{

• struct qcom_pas_tee_private *data = dev_get_drvdata(dev);
• struct tee_ioctl_invoke_arg inv_arg = {

• .func = TA_QCOM_PAS_INIT_IMAGE,
  

• .session = data->session_id,
  

• .num_params = TEE_NUM_PARAMS
  

• };
• struct tee_param param[4] = {

• [0] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = pas_id
  

• },
  

• [1] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_MEMREF_INPUT,
  

• }
  

• };
• struct tee_shm *mdata_shm;
• u8 *mdata_buf = NULL;
• int ret;
• mdata_shm = tee_shm_alloc_kernel_buf(data->ctx, size);
• if (IS_ERR(mdata_shm)) {

• dev_err(dev, "mdata_shm allocation failed\n");
  

• return PTR_ERR(mdata_shm);
  

• }
• mdata_buf = tee_shm_get_va(mdata_shm, 0);
• if (IS_ERR(mdata_buf)) {

• dev_err(dev, "mdata_buf get VA failed\n");
  

• tee_shm_free(mdata_shm);
  

• return PTR_ERR(mdata_buf);
  

• }
• memcpy(mdata_buf, metadata, size);
• param[1].u.memref.shm = mdata_shm;
• param[1].u.memref.size = size;
• ret = tee_client_invoke_func(data->ctx, &inv_arg, param);
• if (ret < 0 || inv_arg.ret != 0) {

• dev_err(dev, "PAS init image failed, pas_id: %d, ret: %d, err: 0x%x\n",
  

• 	pas_id, ret, inv_arg.ret);
  

• tee_shm_free(mdata_shm);
  

• return ret ?: -EINVAL;
  

• }
• if (ctx)

• ctx->ptr = (void *)mdata_shm;
  

• else

• tee_shm_free(mdata_shm);
  

• return ret;

+}

+static int qcom_pas_tee_mem_setup(struct device *dev, u32 pas_id,

• 		  phys_addr_t addr, phys_addr_t size)
  

+{

• struct qcom_pas_tee_private *data = dev_get_drvdata(dev);
• struct tee_ioctl_invoke_arg inv_arg = {

• .func = TA_QCOM_PAS_MEM_SETUP,
  

• .session = data->session_id,
  

• .num_params = TEE_NUM_PARAMS
  

• };
• struct tee_param param[4] = {

• [0] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = pas_id,
  

• 	.u.value.b = size,
  

• },
  

• [1] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = lower_32_bits(addr),
  

• 	.u.value.b = upper_32_bits(addr),
  

• }
  

• };
• int ret;
• ret = tee_client_invoke_func(data->ctx, &inv_arg, param);
• if (ret < 0 || inv_arg.ret != 0) {

• dev_err(dev, "PAS mem setup failed, pas_id: %d, ret: %d, err: 0x%x\n",
  

• 	pas_id, ret, inv_arg.ret);
  

• return ret ?: -EINVAL;
  

• }
• return ret;

+}

+DEFINE_FREE(shm_free, struct tee_shm *, tee_shm_free(_T))

+static void *qcom_pas_tee_get_rsc_table(struct device *dev,

• 			struct qcom_pas_context *ctx,
  

• 			void *input_rt, size_t input_rt_size,
  

• 			size_t *output_rt_size)
  

+{

• struct qcom_pas_tee_private *data = dev_get_drvdata(dev);
• struct tee_ioctl_invoke_arg inv_arg = {

• .func = TA_QCOM_PAS_GET_RESOURCE_TABLE,
  

• .session = data->session_id,
  

• .num_params = TEE_NUM_PARAMS
  

• };
• struct tee_param param[4] = {

• [0] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = ctx->pas_id,
  

• },
  

• [1] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_MEMREF_INOUT,
  

• 	.u.memref.size = input_rt_size,
  

• }
  

• };
• void *rt_buf = NULL;
• int ret;
• ret = tee_client_invoke_func(data->ctx, &inv_arg, param);
• if (ret < 0 || inv_arg.ret != 0) {

• dev_err(dev, "PAS get RT failed, pas_id: %d, ret: %d, err: 0x%x\n",
  

• 	ctx->pas_id, ret, inv_arg.ret);
  

• return ret ? ERR_PTR(ret) : ERR_PTR(-EINVAL);
  

• }
• if (param[1].u.memref.size) {

• struct tee_shm *rt_shm __free(shm_free) =
  

• 	tee_shm_alloc_kernel_buf(data->ctx,
  

• 				 param[1].u.memref.size);
  

• void *rt_shm_va;
  

• if (IS_ERR(rt_shm)) {
  

• 	dev_err(dev, "rt_shm allocation failed\n");
  

• 	return rt_shm;
  

• }
  

• rt_shm_va = tee_shm_get_va(rt_shm, 0);
  

• if (IS_ERR(rt_shm_va)) {
  

• 	dev_err(dev, "rt_shm get VA failed\n");
  

• 	return ERR_CAST(rt_shm_va);
  

• }
  

• memcpy(rt_shm_va, input_rt, input_rt_size);
  

It is very obvious that every existing user will pass NULL as input_rt and 0 as input_rt_size.

Are you not getting NULL pointer on this input_rt ? Ok, you may be not getting because, input_rt_size == 0.

I hope, your backend implementation checks for this num == 0 and then ignore input rt.

rt_shm_va is an INOUT buffer with OP-TEE, if Linux has any RT information to pass then it can pass in this buffer. For current targets nothing is provided by Linux and rt_shm_va will only get populated by OP-TEE with RT information to be consumed by Linux for SMMU configuration.

The total size of rt_shm_va buffer is sum of input RT and output RT sizes. This framework is supported by GP TEE APIs to avoid double memory buffer usage.

...

• param[1].u.memref.shm = rt_shm;
  

• ret = tee_client_invoke_func(data->ctx, &inv_arg, param);
  

• if (ret < 0 || inv_arg.ret != 0) {
  

• 	dev_err(dev, "PAS get RT failed, pas_id: %d, ret: %d, err: 0x%x\n",
  

• 		ctx->pas_id, ret, inv_arg.ret);
  

• 	return ret ? ERR_PTR(ret) : ERR_PTR(-EINVAL);
  

• }
  

• if (param[1].u.memref.size) {
  

• 	*output_rt_size = param[1].u.memref.size;
  

• 	rt_buf = kmemdup(rt_shm_va, *output_rt_size, GFP_KERNEL);
  

• 	if (!rt_buf)
  

• 		return ERR_PTR(-ENOMEM);
  

• }
  

• }
• return rt_buf;

+}

+static int __qcom_pas_tee_auth_and_reset(struct device *dev, u32 pas_id,

• 			 phys_addr_t mem_phys, size_t mem_size)
  

+{

• struct qcom_pas_tee_private *data = dev_get_drvdata(dev);
• struct tee_ioctl_invoke_arg inv_arg = {

• .func = TA_QCOM_PAS_AUTH_AND_RESET,
  

• .session = data->session_id,
  

• .num_params = TEE_NUM_PARAMS
  

• };
• struct tee_param param[4] = {

• [0] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = pas_id,
  

• 	.u.value.b = mem_size,
  

• },
  

• [1] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = lower_32_bits(mem_phys),
  

• 	.u.value.b = upper_32_bits(mem_phys),
  

• },
  

• /* Reserved for fw memory space to be shared or lent */
  

• [2] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_MEMREF_INPUT,
  

• }
  

• };
• int ret;
• ret = tee_client_invoke_func(data->ctx, &inv_arg, param);
• if (ret < 0 || inv_arg.ret != 0) {

• dev_err(dev, "PAS auth reset failed, pas_id: %d, ret: %d, err: 0x%x\n",
  

• 	pas_id, ret, inv_arg.ret);
  

• return ret ?: -EINVAL;
  

• }
• return ret;

+}

+static int qcom_pas_tee_auth_and_reset(struct device *dev, u32 pas_id) +{

• return __qcom_pas_tee_auth_and_reset(dev, pas_id, 0, 0);

+}

+static int qcom_pas_tee_prepare_and_auth_reset(struct device *dev,

• 			       struct qcom_pas_context *ctx)
  

+{

• return __qcom_pas_tee_auth_and_reset(dev, ctx->pas_id, ctx->mem_phys,

• 			     ctx->mem_size);
  

+}

+static int qcom_pas_tee_set_remote_state(struct device *dev, u32 state,

• 			 u32 pas_id)
  

+{

• struct qcom_pas_tee_private *data = dev_get_drvdata(dev);
• struct tee_ioctl_invoke_arg inv_arg = {

• .func = TA_QCOM_PAS_SET_REMOTE_STATE,
  

• .session = data->session_id,
  

• .num_params = TEE_NUM_PARAMS
  

• };
• struct tee_param param[4] = {

• [0] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = pas_id,
  

• 	.u.value.b = state,
  

• }
  

• };
• int ret;
• ret = tee_client_invoke_func(data->ctx, &inv_arg, param);
• if (ret < 0 || inv_arg.ret != 0) {

• dev_err(dev, "PAS shutdown failed, pas_id: %d, ret: %d, err: 0x%x\n",
  

• 	pas_id, ret, inv_arg.ret);
  

should be "PAS set remote state failed .."

Ack.

...

• return ret ?: -EINVAL;
  

• }
• return ret;

+}

+static int qcom_pas_tee_shutdown(struct device *dev, u32 pas_id) +{

• struct qcom_pas_tee_private *data = dev_get_drvdata(dev);
• struct tee_ioctl_invoke_arg inv_arg = {

• .func = TA_QCOM_PAS_SHUTDOWN,
  

• .session = data->session_id,
  

• .num_params = TEE_NUM_PARAMS
  

• };
• struct tee_param param[4] = {

• [0] = {
  

• 	.attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT,
  

• 	.u.value.a = pas_id
  

• }
  

• };
• int ret;
• ret = tee_client_invoke_func(data->ctx, &inv_arg, param);
• if (ret < 0 || inv_arg.ret != 0) {

• dev_err(dev, "PAS shutdown failed, pas_id: %d, ret: %d, err: 0x%x\n",
  

• 	pas_id, ret, inv_arg.ret);
  

• return ret ?: -EINVAL;
  

• }
• return ret;

+}

+static void qcom_pas_tee_metadata_release(struct device *dev,

• 			  struct qcom_pas_context *ctx)
  

+{

• struct tee_shm *mdata_shm = ctx->ptr;
• tee_shm_free(mdata_shm);

+}

+static struct qcom_pas_ops qcom_pas_ops_tee = {

• .drv_name = "qcom-pas-tee",
• .supported = qcom_pas_tee_supported,
• .init_image = qcom_pas_tee_init_image,
• .mem_setup = qcom_pas_tee_mem_setup,
• .get_rsc_table = qcom_pas_tee_get_rsc_table,
• .auth_and_reset = qcom_pas_tee_auth_and_reset,
• .prepare_and_auth_reset = qcom_pas_tee_prepare_and_auth_reset,
• .set_remote_state = qcom_pas_tee_set_remote_state,
• .shutdown = qcom_pas_tee_shutdown,
• .metadata_release = qcom_pas_tee_metadata_release,

+};

+static int optee_ctx_match(struct tee_ioctl_version_data *ver, const void *data) +{

• return ver->impl_id == TEE_IMPL_ID_OPTEE;

+}

+static int qcom_pas_tee_probe(struct tee_client_device *pas_dev) +{

• struct device *dev = &pas_dev->dev;
• struct qcom_pas_tee_private *data;
• struct tee_ioctl_open_session_arg sess_arg = {

• .clnt_login = TEE_IOCTL_LOGIN_REE_KERNEL
  

• };
• int ret, err = -ENODEV;

Most people prefer one line per variable..

Ack.

...

• data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
• if (!data)

• return -ENOMEM;
  

• data->ctx = tee_client_open_context(NULL, optee_ctx_match, NULL, NULL);
• if (IS_ERR(data->ctx))

• return -ENODEV;
  

• export_uuid(sess_arg.uuid, &pas_dev->id.uuid);
• ret = tee_client_open_session(data->ctx, &sess_arg, NULL);
• if (ret < 0 || sess_arg.ret != 0) {

• dev_err(dev, "tee_client_open_session failed, ret: %d, err: 0x%x\n",
  

• 	ret, sess_arg.ret);
  

• err = ret ?: -EINVAL;
  

Only user of goto, we can close the context and return from here and 'err' not used.

Ack.

tee_client_close_context(data->ctx);
return ret ?: -EINVAL;

...

• goto out_ctx;
  

...

• }
• data->session_id = sess_arg.session;
• dev_set_drvdata(dev, data);
• qcom_pas_ops_tee.dev = dev;
• qcom_pas_ops_register(&qcom_pas_ops_tee);
• return ret;

+out_ctx:

• tee_client_close_context(data->ctx);

Return after two line does not look nice.

...

• return err;

+}

+static void qcom_pas_tee_remove(struct tee_client_device *pas_dev) +{

• struct device *dev = &pas_dev->dev;
• struct qcom_pas_tee_private *data = dev_get_drvdata(dev);
• qcom_pas_ops_unregister();
• tee_client_close_session(data->ctx, data->session_id);
• tee_client_close_context(data->ctx);

+}

+static const struct tee_client_device_id qcom_pas_tee_id_table[] = {

• {UUID_INIT(0xcff7d191, 0x7ca0, 0x4784,

•    0xaf, 0x13, 0x48, 0x22, 0x3b, 0x9a, 0x4f, 0xbe)},
  

• {}

+}; +MODULE_DEVICE_TABLE(tee, qcom_pas_tee_id_table);

+static struct tee_client_driver optee_pas_tee_driver = {

• .probe = qcom_pas_tee_probe,
• .remove = qcom_pas_tee_remove,
• .id_table = qcom_pas_tee_id_table,
• .driver = {

• .name		= "qcom-pas-tee",
  

• },

+};

+module_tee_client_driver(optee_pas_tee_driver);

+MODULE_LICENSE("GPL");

+MODULE_DESCRIPTION("Qualcomm PAS TEE driver");

2.51.0

With above change,

Reviewed-by: Mukesh Ojha mukesh.ojha@oss.qualcomm.com

Thanks.

-Sumit

On Wed, Apr 29, 2026 at 06:55:12PM +0530, Mukesh Ojha wrote:

On Mon, Apr 27, 2026 at 03:25:53PM +0530, Sumit Garg wrote:

...

From: Sumit Garg sumit.garg@oss.qualcomm.com

Switch qcom_q6v5_pas client driver over to generic PAS TZ APIs. Generic PAS TZ service allows to support multiple TZ implementation backends like QTEE based SCM PAS service, OP-TEE based PAS service and any further future TZ backend service.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/remoteproc/qcom_q6v5_pas.c | 51 +++++++++++++++--------------- 1 file changed, 26 insertions(+), 25 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index da27d1d3c9da..847249c28c1b 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -20,6 +20,7 @@ #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/pm_runtime.h> +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/firmware/qcom/qcom_scm.h>

Can you check do we really need this header ?

Yeah it's needed for qcom_scm_assign_mem() API.

...

#include <linux/regulator/consumer.h> #include <linux/remoteproc.h> @@ -118,8 +119,8 @@ struct qcom_pas { struct qcom_rproc_ssr ssr_subdev; struct qcom_sysmon *sysmon;

• struct qcom_scm_pas_context *pas_ctx;
• struct qcom_scm_pas_context *dtb_pas_ctx;

• struct qcom_pas_context *pas_ctx;
• struct qcom_pas_context *dtb_pas_ctx;

}; static void qcom_pas_segment_dump(struct rproc *rproc, @@ -196,7 +197,7 @@ static int qcom_pas_shutdown_poll_decrypt(struct qcom_pas *pas) do { msleep(QCOM_PAS_DECRYPT_SHUTDOWN_DELAY_MS);

• ret = qcom_scm_pas_shutdown(pas->pas_id);
  

• ret = qcom_pas_shutdown(pas->pas_id);
  

  } while (ret == -EINVAL && --retry_num);

return ret; @@ -212,9 +213,9 @@ static int qcom_pas_unprepare(struct rproc *rproc) * auth_and_reset() was successful, but in other cases clean it up * here. */

• qcom_scm_pas_metadata_release(pas->pas_ctx);

• qcom_pas_metadata_release(pas->pas_ctx); if (pas->dtb_pas_id)

• qcom_scm_pas_metadata_release(pas->dtb_pas_ctx);
  

• qcom_pas_metadata_release(pas->dtb_pas_ctx);
  

return 0; } @@ -228,9 +229,9 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw) pas->firmware = fw; if (pas->lite_pas_id)

• qcom_scm_pas_shutdown(pas->lite_pas_id);
  

• qcom_pas_shutdown(pas->lite_pas_id);
  

  if (pas->lite_dtb_pas_id)

• qcom_scm_pas_shutdown(pas->lite_dtb_pas_id);
  

• qcom_pas_shutdown(pas->lite_dtb_pas_id);
  

if (pas->dtb_pas_id) { ret = request_firmware(&pas->dtb_firmware, pas->dtb_firmware_name, pas->dev); @@ -250,7 +251,7 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw) return 0; release_dtb_metadata:

• qcom_scm_pas_metadata_release(pas->dtb_pas_ctx);

• qcom_pas_metadata_release(pas->dtb_pas_ctx); release_firmware(pas->dtb_firmware);

return ret; @@ -310,7 +311,7 @@ static int qcom_pas_start(struct rproc *rproc) if (ret) goto disable_px_supply;

• ret = qcom_scm_pas_prepare_and_auth_reset(pas->dtb_pas_ctx);
  

• ret = qcom_pas_prepare_and_auth_reset(pas->dtb_pas_ctx);
  

  if (ret) { dev_err(pas->dev, "failed to authenticate dtb image and release reset\n");

@@ -329,7 +330,7 @@ static int qcom_pas_start(struct rproc *rproc) if (ret) goto release_pas_metadata;

• ret = qcom_scm_pas_prepare_and_auth_reset(pas->pas_ctx);

• ret = qcom_pas_prepare_and_auth_reset(pas->pas_ctx); if (ret) { dev_err(pas->dev, "failed to authenticate image and release reset\n");

@@ -339,13 +340,13 @@ static int qcom_pas_start(struct rproc *rproc) ret = qcom_q6v5_wait_for_start(&pas->q6v5, msecs_to_jiffies(5000)); if (ret == -ETIMEDOUT) { dev_err(pas->dev, "start timed out\n");

• qcom_scm_pas_shutdown(pas->pas_id);
  

• qcom_pas_shutdown(pas->pas_id);
  

  goto unmap_carveout; }

• qcom_scm_pas_metadata_release(pas->pas_ctx);

• qcom_pas_metadata_release(pas->pas_ctx); if (pas->dtb_pas_id)

• qcom_scm_pas_metadata_release(pas->dtb_pas_ctx);
  

• qcom_pas_metadata_release(pas->dtb_pas_ctx);
  

/* firmware is used to pass reference from qcom_pas_start(), drop it now */ pas->firmware = NULL; @@ -355,9 +356,9 @@ static int qcom_pas_start(struct rproc *rproc) unmap_carveout: qcom_pas_unmap_carveout(rproc, pas->mem_phys, pas->mem_size); release_pas_metadata:

• qcom_scm_pas_metadata_release(pas->pas_ctx);

• qcom_pas_metadata_release(pas->pas_ctx); if (pas->dtb_pas_id)

• qcom_scm_pas_metadata_release(pas->dtb_pas_ctx);
  

• qcom_pas_metadata_release(pas->dtb_pas_ctx);
  

unmap_dtb_carveout: if (pas->dtb_pas_id) @@ -406,7 +407,7 @@ static int qcom_pas_stop(struct rproc *rproc) if (ret == -ETIMEDOUT) dev_err(pas->dev, "timed out on wait\n");

• ret = qcom_scm_pas_shutdown(pas->pas_id);

• ret = qcom_pas_shutdown(pas->pas_id); if (ret && pas->decrypt_shutdown) ret = qcom_pas_shutdown_poll_decrypt(pas);

@@ -414,7 +415,7 @@ static int qcom_pas_stop(struct rproc *rproc) dev_err(pas->dev, "failed to shutdown: %d\n", ret); if (pas->dtb_pas_id) {

• ret = qcom_scm_pas_shutdown(pas->dtb_pas_id);
  

• ret = qcom_pas_shutdown(pas->dtb_pas_id);
  

  if (ret) dev_err(pas->dev, "failed to shutdown dtb: %d\n", ret);

@@ -484,11 +485,11 @@ static int qcom_pas_parse_firmware(struct rproc *rproc, const struct firmware *f * * Here, we call rproc_elf_load_rsc_table() to check firmware binary has resources * or not and if it is not having then we pass NULL and zero as input resource

• * table pointer and size respectively to the argument of qcom_scm_pas_get_rsc_table()
  

• * table pointer and size respectively to the argument of qcom_pas_get_rsc_table()
  

  • and this is even true for Qualcomm remote processor who does follow remoteproc
  • framework.
  */

• output_rt = qcom_scm_pas_get_rsc_table(pas->pas_ctx, table, table_sz, &output_rt_size);

• output_rt = qcom_pas_get_rsc_table(pas->pas_ctx, table, table_sz, &output_rt_size); ret = IS_ERR(output_rt) ? PTR_ERR(output_rt) : 0; if (ret) { dev_err(pas->dev, "Error in getting resource table: %d\n", ret);

@@ -746,7 +747,7 @@ static int qcom_pas_probe(struct platform_device *pdev) if (!desc) return -EINVAL;

• if (!qcom_scm_is_available())

• if (!qcom_pas_is_available()) return -EPROBE_DEFER;

fw_name = desc->firmware_name; @@ -838,16 +839,16 @@ static int qcom_pas_probe(struct platform_device *pdev) qcom_add_ssr_subdev(rproc, &pas->ssr_subdev, desc->ssr_name);

• pas->pas_ctx = devm_qcom_scm_pas_context_alloc(pas->dev, pas->pas_id,

• 				       pas->mem_phys, pas->mem_size);
  

• pas->pas_ctx = devm_qcom_pas_context_alloc(pas->dev, pas->pas_id,

• 				   pas->mem_phys, pas->mem_size);
  

  if (IS_ERR(pas->pas_ctx)) { ret = PTR_ERR(pas->pas_ctx); goto remove_ssr_sysmon; }

• pas->dtb_pas_ctx = devm_qcom_scm_pas_context_alloc(pas->dev, pas->dtb_pas_id,

• 					   pas->dtb_mem_phys,
  

• 					   pas->dtb_mem_size);
  

• pas->dtb_pas_ctx = devm_qcom_pas_context_alloc(pas->dev, pas->dtb_pas_id,

• 				       pas->dtb_mem_phys,
  

• 				       pas->dtb_mem_size);
  

  if (IS_ERR(pas->dtb_pas_ctx)) { ret = PTR_ERR(pas->dtb_pas_ctx); goto remove_ssr_sysmon;

-- 2.51.0

Reviewed-by: Mukesh Ojha mukesh.ojha@oss.qualcomm.com

Thanks.

-Sumit

On Mon, Apr 27, 2026 at 03:25:54PM +0530, Sumit Garg wrote:

From: Sumit Garg sumit.garg@oss.qualcomm.com

Switch qcom_q6v5_mss client driver over to generic PAS TZ APIs. Generic PAS TZ service allows to support multiple TZ implementation backends like QTEE based SCM PAS service, OP-TEE based PAS service and any further future TZ backend service.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/remoteproc/qcom_q6v5_mss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c index ae78f5c7c1b6..96888007faa8 100644 --- a/drivers/remoteproc/qcom_q6v5_mss.c +++ b/drivers/remoteproc/qcom_q6v5_mss.c @@ -34,6 +34,7 @@ #include "qcom_pil_info.h" #include "qcom_q6v5.h" +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/firmware/qcom/qcom_scm.h>

same here., whether it is needed now ?

#define MPSS_CRASH_REASON_SMEM 421 @@ -1480,7 +1481,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc) } if (qproc->need_pas_mem_setup) {

• ret = qcom_scm_pas_mem_setup(MPSS_PAS_ID, qproc->mpss_phys, qproc->mpss_size);
  

• ret = qcom_pas_mem_setup(MPSS_PAS_ID, qproc->mpss_phys, qproc->mpss_size);
  

  if (ret) { dev_err(qproc->dev, "setting up mpss memory failed: %d\n", ret);

@@ -2077,7 +2078,7 @@ static int q6v5_probe(struct platform_device *pdev) if (!desc) return -EINVAL;

• if (desc->need_mem_protection && !qcom_scm_is_available())

• if (desc->need_mem_protection && !qcom_pas_is_available()) return -EPROBE_DEFER;

mba_image = desc->hexagon_mba_image;

Reviewed-by: Mukesh Ojha mukesh.ojha@oss.qualcomm.com

-- 2.51.0

On Wed, Apr 29, 2026 at 07:12:08PM +0530, Mukesh Ojha wrote:

On Mon, Apr 27, 2026 at 03:25:55PM +0530, Sumit Garg wrote:

...

From: Sumit Garg sumit.garg@oss.qualcomm.com

Switch mdtloader client driver over to generic PAS TZ APIs. Generic PAS TZ service allows to support multiple TZ implementation backends like QTEE based SCM PAS service, OP-TEE based PAS service and any further future TZ backend service.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/soc/qcom/mdt_loader.c | 12 ++++++------ include/linux/soc/qcom/mdt_loader.h | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c index c004d444d698..fdde7eda538a 100644 --- a/drivers/soc/qcom/mdt_loader.c +++ b/drivers/soc/qcom/mdt_loader.c @@ -13,7 +13,7 @@ #include <linux/firmware.h> #include <linux/kernel.h> #include <linux/module.h> -#include <linux/firmware/qcom/qcom_scm.h> +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/sizes.h> #include <linux/slab.h> #include <linux/soc/qcom/mdt_loader.h> @@ -229,7 +229,7 @@ EXPORT_SYMBOL_GPL(qcom_mdt_read_metadata); static int __qcom_mdt_pas_init(struct device *dev, const struct firmware *fw, const char *fw_name, int pas_id, phys_addr_t mem_phys,

• 	       struct qcom_scm_pas_context *ctx)
  

• 	       struct qcom_pas_context *ctx)
  

{ const struct elf32_phdr *phdrs; const struct elf32_phdr *phdr; @@ -271,7 +271,7 @@ static int __qcom_mdt_pas_init(struct device *dev, const struct firmware *fw, goto out; }

• ret = qcom_scm_pas_init_image(pas_id, metadata, metadata_len, ctx);

• ret = qcom_pas_init_image(pas_id, metadata, metadata_len, ctx); kfree(metadata); if (ret) { /* Invalid firmware metadata */

@@ -280,7 +280,7 @@ static int __qcom_mdt_pas_init(struct device *dev, const struct firmware *fw, } if (relocate) {

• ret = qcom_scm_pas_mem_setup(pas_id, mem_phys, max_addr - min_addr);
  

• ret = qcom_pas_mem_setup(pas_id, mem_phys, max_addr - min_addr);
  

  if (ret) { /* Unable to set up relocation */ dev_err(dev, "error %d setting up firmware %s\n", ret, fw_name);

@@ -472,7 +472,7 @@ EXPORT_SYMBOL_GPL(qcom_mdt_load);

• firmware segments (e.g., .bXX files). Authentication of the segments done
• by a separate call.

• • The PAS context must be initialized using qcom_scm_pas_context_init()

• • The PAS context must be initialized using qcom_pas_context_init()

Should devm_qcom_pas_context_alloc() now

Ack.

...

• prior to invoking this function.
• @ctx: Pointer to the PAS (Peripheral Authentication Service) context

@@ -483,7 +483,7 @@ EXPORT_SYMBOL_GPL(qcom_mdt_load);

• Return: 0 on success or a negative error code on failure.

*/ -int qcom_mdt_pas_load(struct qcom_scm_pas_context *ctx, const struct firmware *fw, +int qcom_mdt_pas_load(struct qcom_pas_context *ctx, const struct firmware *fw, const char *firmware, void *mem_region, phys_addr_t *reloc_base) { int ret; diff --git a/include/linux/soc/qcom/mdt_loader.h b/include/linux/soc/qcom/mdt_loader.h index 82372e0db0a1..142409555425 100644 --- a/include/linux/soc/qcom/mdt_loader.h +++ b/include/linux/soc/qcom/mdt_loader.h @@ -10,7 +10,7 @@ struct device; struct firmware; -struct qcom_scm_pas_context; +struct qcom_pas_context; #if IS_ENABLED(CONFIG_QCOM_MDT_LOADER) @@ -20,7 +20,7 @@ int qcom_mdt_load(struct device *dev, const struct firmware *fw, phys_addr_t mem_phys, size_t mem_size, phys_addr_t *reloc_base); -int qcom_mdt_pas_load(struct qcom_scm_pas_context *ctx, const struct firmware *fw, +int qcom_mdt_pas_load(struct qcom_pas_context *ctx, const struct firmware *fw, const char *firmware, void *mem_region, phys_addr_t *reloc_base); int qcom_mdt_load_no_init(struct device *dev, const struct firmware *fw, @@ -45,7 +45,7 @@ static inline int qcom_mdt_load(struct device *dev, const struct firmware *fw, return -ENODEV; } -static inline int qcom_mdt_pas_load(struct qcom_scm_pas_context *ctx, +static inline int qcom_mdt_pas_load(struct qcom_pas_context *ctx, const struct firmware *fw, const char *firmware, void *mem_region, phys_addr_t *reloc_base) { -- 2.51.0

With above nit

Reviewed-by: Mukesh Ojha mukesh.ojha@oss.qualcomm.com

Thanks.

-Sumit

On Mon, Apr 27, 2026 at 03:25:56PM +0530, Sumit Garg wrote:

From: Sumit Garg sumit.garg@oss.qualcomm.com

Switch qcom_wcnss client driver over to generic PAS TZ APIs. Generic PAS TZ service allows to support multiple TZ implementation backends like QTEE based SCM PAS service, OP-TEE based PAS service and any further future TZ backend service.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/remoteproc/qcom_wcnss.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c index 4add9037dbd5..0dbdd18ab3dd 100644 --- a/drivers/remoteproc/qcom_wcnss.c +++ b/drivers/remoteproc/qcom_wcnss.c @@ -19,7 +19,7 @@ #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/pm_runtime.h> -#include <linux/firmware/qcom/qcom_scm.h> +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/regulator/consumer.h> #include <linux/remoteproc.h> #include <linux/soc/qcom/mdt_loader.h> @@ -257,7 +257,7 @@ static int wcnss_start(struct rproc *rproc) wcnss_indicate_nv_download(wcnss); wcnss_configure_iris(wcnss);

• ret = qcom_scm_pas_auth_and_reset(WCNSS_PAS_ID);

• ret = qcom_pas_auth_and_reset(WCNSS_PAS_ID); if (ret) { dev_err(wcnss->dev, "failed to authenticate image and release reset\n");

@@ -269,7 +269,7 @@ static int wcnss_start(struct rproc *rproc) if (wcnss->ready_irq > 0 && ret == 0) { /* We have a ready_irq, but it didn't fire in time. */ dev_err(wcnss->dev, "start timed out\n");

• qcom_scm_pas_shutdown(WCNSS_PAS_ID);
  

• qcom_pas_shutdown(WCNSS_PAS_ID);
  

  ret = -ETIMEDOUT; goto disable_iris; }

@@ -311,7 +311,7 @@ static int wcnss_stop(struct rproc *rproc) 0); }

• ret = qcom_scm_pas_shutdown(WCNSS_PAS_ID);

• ret = qcom_pas_shutdown(WCNSS_PAS_ID); if (ret) dev_err(wcnss->dev, "failed to shutdown: %d\n", ret);

@@ -557,10 +557,10 @@ static int wcnss_probe(struct platform_device *pdev) data = of_device_get_match_data(&pdev->dev);

• if (!qcom_scm_is_available())

• if (!qcom_pas_is_available()) return -EPROBE_DEFER;

• if (!qcom_scm_pas_supported(WCNSS_PAS_ID)) {

• if (!qcom_pas_supported(WCNSS_PAS_ID)) { dev_err(&pdev->dev, "PAS is not available for WCNSS\n"); return -ENXIO; }

Reviewed-by: Mukesh Ojha mukesh.ojha@oss.qualcomm.com

-- 2.51.0

On Mon, Apr 27, 2026 at 03:25:57PM +0530, Sumit Garg wrote:

From: Sumit Garg sumit.garg@oss.qualcomm.com

Select PAS generic service driver to enable support for multiple PAS backends like OP-TEE in addition to SCM.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/remoteproc/Kconfig | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig index ee54436fea5a..da3c5d9562ea 100644 --- a/drivers/remoteproc/Kconfig +++ b/drivers/remoteproc/Kconfig @@ -230,6 +230,7 @@ config QCOM_Q6V5_PAS select QCOM_Q6V5_COMMON select QCOM_RPROC_COMMON select QCOM_SCM

Check do we really need SCM now ? Why not the change for WCNSS, MSS ?

• select QCOM_PAS help Say y here to support the TrustZone based Peripheral Image Loader for the Qualcomm remote processors. This is commonly used to control

-- 2.51.0

On Wed, Apr 29, 2026 at 07:29:54PM +0530, Mukesh Ojha wrote:

On Mon, Apr 27, 2026 at 03:25:58PM +0530, Sumit Garg wrote:

...

From: Sumit Garg sumit.garg@oss.qualcomm.com

Switch drm/msm client drivers over to generic PAS TZ APIs. Generic PAS TZ service allows to support multiple TZ implementation backends like QTEE based SCM PAS service, OP-TEE based PAS service and any further future TZ backend service.

Acked-by: Dmitry Baryshkov dmitry.baryshkov@oss.qualcomm.com Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

---

drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 11 ++++++----- 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gdrivers/gpu/drm/msm/Kconfigpu/drm/msm/Kconfig index 250246f81ea9..09469d56513b 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -21,6 +21,7 @@ config DRM_MSM select SHMEM select TMPFS select QCOM_SCM

do we need this ?

Yeah we do..

...

• select QCOM_PAS select QCOM_UBWC_CONFIG select WANT_DEV_COREDUMP select SND_SOC_HDMI_CODEC if SND_SOC

diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c index 79acae11154a..b556da823897 100644 --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c @@ -5,7 +5,7 @@ #include <linux/kernel.h> #include <linux/types.h> #include <linux/cpumask.h> -#include <linux/firmware/qcom/qcom_scm.h> +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/pm_opp.h> #include <linux/nvmem-consumer.h> #include <linux/slab.h> @@ -653,7 +653,7 @@ static int a5xx_zap_shader_resume(struct msm_gpu *gpu) if (adreno_is_a506(adreno_gpu)) return 0;

• ret = qcom_scm_set_remote_state(SCM_GPU_ZAP_SHADER_RESUME, GPU_PAS_ID);

• ret = qcom_pas_set_remote_state(SCM_GPU_ZAP_SHADER_RESUME, GPU_PAS_ID); if (ret) DRM_ERROR("%s: zap-shader resume failed: %d\n", gpu->name, ret);

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..6d68edf0578c 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -8,6 +8,7 @@ #include <linux/ascii85.h> #include <linux/interconnect.h> +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/firmware/qcom/qcom_scm.h>

do we need this ?

..needed for qcom_scm_set_gpu_smmu_aperture() API.

...

#include <linux/kernel.h> #include <linux/of_reserved_mem.h> @@ -146,10 +147,10 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname, goto out; /* Send the image to the secure world */

• ret = qcom_scm_pas_auth_and_reset(pasid);

• ret = qcom_pas_auth_and_reset(pasid);

/*

• * If the scm call returns -EOPNOTSUPP we assume that this target
  

• * If the pas call returns -EOPNOTSUPP we assume that this target
  

  • doesn't need/support the zap shader so quietly fail
  */ if (ret == -EOPNOTSUPP)

@@ -175,9 +176,9 @@ int adreno_zap_shader_load(struct msm_gpu *gpu, u32 pasid) if (!zap_available) return -ENODEV;

• /* We need SCM to be able to load the firmware */
• if (!qcom_scm_is_available()) {

• DRM_DEV_ERROR(&pdev->dev, "SCM is not available\n");
  

• /* We need PAS to be able to load the firmware */
• if (!qcom_pas_is_available()) {

• DRM_DEV_ERROR(&pdev->dev, "Qcom PAS is not available\n");
  

  return -EPROBE_DEFER; }

2.51.0

Reviewed-by: Mukesh Ojha mukesh.ojha@oss.qualcomm.com

Thanks.

-Sumit

On Mon, Apr 27, 2026 at 03:25:59PM +0530, Sumit Garg wrote:

From: Sumit Garg sumit.garg@oss.qualcomm.com

Switch qcom media client drivers over to generic PAS TZ APIs. Generic PAS TZ service allows to support multiple TZ implementation backends like QTEE based SCM PAS service, OP-TEE based PAS service and any further future TZ backend service.

Along with that pass proper PAS ID to set_remote_state API. As per testing the SCM backend just ignores it while OP-TEE makes use of it to for proper book keeping purpose.

When we use 'Along with' or 'while at it', patch is doing two things and not one.

Signed-off-by: Sumit Garg sumit.garg@oss.qualcomm.com

drivers/media/platform/qcom/iris/Kconfig | 25 ++++++++++--------- .../media/platform/qcom/iris/iris_firmware.c | 9 ++++--- drivers/media/platform/qcom/venus/Kconfig | 1 + drivers/media/platform/qcom/venus/firmware.c | 11 ++++---- 4 files changed, 25 insertions(+), 21 deletions(-)

diff --git a/drivers/media/platform/qcom/iris/Kconfig b/drivers/media/platform/qcom/iris/Kconfig index 3c803a05305a..f54b759c18aa 100644 --- a/drivers/media/platform/qcom/iris/Kconfig +++ b/drivers/media/platform/qcom/iris/Kconfig @@ -1,13 +1,14 @@ config VIDEO_QCOM_IRIS

•    tristate "Qualcomm iris V4L2 decoder driver"
  

•    depends on VIDEO_DEV
  

•    depends on ARCH_QCOM || COMPILE_TEST
  

•    select V4L2_MEM2MEM_DEV
  

•    select QCOM_MDT_LOADER if ARCH_QCOM
  

•    select QCOM_SCM
  

•    select VIDEOBUF2_DMA_CONTIG
  

•    help
  

•      This is a V4L2 driver for Qualcomm iris video accelerator
  

•      hardware. It accelerates decoding operations on various
  

•      Qualcomm SoCs.
  

•      To compile this driver as a module choose m here.
  

• tristate "Qualcomm iris V4L2 decoder driver"
• depends on VIDEO_DEV
• depends on ARCH_QCOM || COMPILE_TEST
• select V4L2_MEM2MEM_DEV
• select QCOM_MDT_LOADER if ARCH_QCOM
• select QCOM_SCM
• select QCOM_PAS
• select VIDEOBUF2_DMA_CONTIG
• help

•  This is a V4L2 driver for Qualcomm iris video accelerator
  

•  hardware. It accelerates decoding operations on various
  

•  Qualcomm SoCs.
  

•  To compile this driver as a module choose m here.
  

Here, Space replaced by Tabs just for one line.., should be fine.

diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c index 5f408024e967..856fa6a79064 100644 --- a/drivers/media/platform/qcom/iris/iris_firmware.c +++ b/drivers/media/platform/qcom/iris/iris_firmware.c @@ -4,6 +4,7 @@ */ #include <linux/firmware.h> +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/firmware/qcom/qcom_scm.h> #include <linux/of_address.h> #include <linux/of_reserved_mem.h> @@ -79,7 +80,7 @@ int iris_fw_load(struct iris_core *core) return -ENOMEM; }

• ret = qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id);

• ret = qcom_pas_auth_and_reset(core->iris_platform_data->pas_id); if (ret) { dev_err(core->dev, "auth and reset failed: %d\n", ret); return ret;

@@ -93,7 +94,7 @@ int iris_fw_load(struct iris_core *core) cp_config->cp_nonpixel_size); if (ret) { dev_err(core->dev, "qcom_scm_mem_protect_video_var failed: %d\n", ret);

• 	qcom_scm_pas_shutdown(core->iris_platform_data->pas_id);
  

• 	qcom_pas_shutdown(core->iris_platform_data->pas_id);
  return ret;
  

  } }

@@ -103,10 +104,10 @@ int iris_fw_load(struct iris_core *core) int iris_fw_unload(struct iris_core *core) {

• return qcom_scm_pas_shutdown(core->iris_platform_data->pas_id);

• return qcom_pas_shutdown(core->iris_platform_data->pas_id);

} int iris_set_hw_state(struct iris_core *core, bool resume) {

• return qcom_scm_set_remote_state(resume, 0);

• return qcom_pas_set_remote_state(resume, core->irisi_platform_data->pas_id);

Should be a separate change for qcom_pas_set_remote_state()

} diff --git a/drivers/media/platform/qcom/venus/Kconfig b/drivers/media/platform/qcom/venus/Kconfig index ffb731ecd48c..574172724e8f 100644 --- a/drivers/media/platform/qcom/venus/Kconfig +++ b/drivers/media/platform/qcom/venus/Kconfig @@ -6,6 +6,7 @@ config VIDEO_QCOM_VENUS select OF_DYNAMIC if ARCH_QCOM select QCOM_MDT_LOADER if ARCH_QCOM select QCOM_SCM

• select QCOM_PAS select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV help

diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c index 1de7436713ed..3c0727ea137d 100644 --- a/drivers/media/platform/qcom/venus/firmware.c +++ b/drivers/media/platform/qcom/venus/firmware.c @@ -12,6 +12,7 @@ #include <linux/of_reserved_mem.h> #include <linux/platform_device.h> #include <linux/of_device.h> +#include <linux/firmware/qcom/qcom_pas.h> #include <linux/firmware/qcom/qcom_scm.h> #include <linux/sizes.h> #include <linux/soc/qcom/mdt_loader.h> @@ -58,7 +59,7 @@ int venus_set_hw_state(struct venus_core *core, bool resume) int ret; if (core->use_tz) {

• ret = qcom_scm_set_remote_state(resume, 0);
  

• ret = qcom_pas_set_remote_state(resume, VENUS_PAS_ID);
  

This too..

if (resume && ret == -EINVAL)
	ret = 0;
return ret;

@@ -218,7 +219,7 @@ int venus_boot(struct venus_core *core) int ret; if (!IS_ENABLED(CONFIG_QCOM_MDT_LOADER) ||

•    (core->use_tz && !qcom_scm_is_available()))
  

•    (core->use_tz && !qcom_pas_is_available()))
  

  return -EPROBE_DEFER;

ret = of_property_read_string_index(dev->of_node, "firmware-name", 0, @@ -236,7 +237,7 @@ int venus_boot(struct venus_core *core) core->fw.mem_phys = mem_phys; if (core->use_tz)

• ret = qcom_scm_pas_auth_and_reset(VENUS_PAS_ID);
  

• ret = qcom_pas_auth_and_reset(VENUS_PAS_ID);
  

  else ret = venus_boot_no_tz(core, mem_phys, mem_size);

@@ -259,7 +260,7 @@ int venus_boot(struct venus_core *core) res->cp_nonpixel_start, res->cp_nonpixel_size); if (ret) {

• 	qcom_scm_pas_shutdown(VENUS_PAS_ID);
  

• 	qcom_pas_shutdown(VENUS_PAS_ID);
  dev_err(dev, "set virtual address ranges fail (%d)\n",
  	ret);
  return ret;
  

@@ -274,7 +275,7 @@ int venus_shutdown(struct venus_core *core) int ret; if (core->use_tz)

• ret = qcom_scm_pas_shutdown(VENUS_PAS_ID);
  

• ret = qcom_pas_shutdown(VENUS_PAS_ID);
  

  else ret = venus_shutdown_no_tz(core);

2.51.0