Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
** CID 506279: Code maintainability issues (UNUSED_VALUE)
/plat/altera/soc/common/drivers/mailbox/mcsr/socfpga_mcsr_mailbox.c: 360 in mcsr_mailbox_response_handler()
_____________________________________________________________________________________________
*** CID 506279: Code maintainability issues (UNUSED_VALUE)
/plat/altera/soc/common/drivers/mailbox/mcsr/socfpga_mcsr_mailbox.c: 360 in mcsr_mailbox_response_handler()
354
355 uint32_t response_header = response_buffer[get_index].msg_header;
356 uint8_t trans_id;
357
358 di = mcsr_mailbox_get_free_resp_desc();
359 if (di == -1) {
>>> CID 506279: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value "-1" to "status" here, but that stored value is overwritten before it can be used.
360 status = MBOX_RET_ERROR;
361 break;
362 }
363
364 /* Populate the local response queue entry */
365 mbox_svc.resp_queue[di].header = response_header;
** CID 506278: Uninitialized variables (UNINIT)
/plat/altera/soc/common/socfpga_sip_svc.c: 277 in intel_fpga_config_start()
_____________________________________________________________________________________________
*** CID 506278: Uninitialized variables (UNINIT)
/plat/altera/soc/common/socfpga_sip_svc.c: 277 in intel_fpga_config_start()
271 if (status < 0) {
272 bridge_disable = false;
273 request_type = NO_REQUEST;
274 return INTEL_SIP_SMC_STATUS_ERROR;
275 }
276
>>> CID 506278: Uninitialized variables (UNINIT)
>>> Using uninitialized value "response[0]".
277 max_blocks = response[0];
278 bytes_per_block = response[1];
279
280 for (int i = 0; i < FPGA_CONFIG_BUFFER_SIZE; i++) {
281 fpga_config_buffers[i].size = 0;
282 fpga_config_buffers[i].size_written = 0;
** CID 506277: Code maintainability issues (UNUSED_VALUE)
/services/std_svc/firme/firme_attestation.c: 212 in firme_attest_pat_get()
_____________________________________________________________________________________________
*** CID 506277: Code maintainability issues (UNUSED_VALUE)
/services/std_svc/firme/firme_attestation.c: 212 in firme_attest_pat_get()
206 mmap_rc = mmap_remove_dynamic_region(shared_buf_addr,
207 shared_buf_size);
208 if (mmap_rc != 0U) {
209 if (mmap_rc != -ENOMEM) {
210 ERROR("%s(): mmap_remove_dynamic_region() failed unexpectedly rc=%d\n",
211 __func__, mmap_rc);
>>> CID 506277: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value "-10" to "rc" here, but that stored value is overwritten before it can be used.
212 rc = FIRME_NO_MEMORY;
213 }
214
215 rc = FIRME_INVALID_PARAMETERS;
216 }
217 }
Best regards,
The Coverity Scan Admin Team
