Hello Joanna,

From my experience so far, I can think of the following problems with the current approach

- we don’t know who to add as a reviewer when we push our changes to gerrit - we don’t know where we are in the review queue - we don’t know what the ETA would be to receive the first review comment - the reviewers are only from ARM adding to the workload of the team and thus increasing the latency

Off the top of my head I think this might be helpful. Feel free to disagree.

- provide a list of reviewers that can be contacted when we push changes to gerrit - provide a mechanism to remind reviewers of the changes that have not been reviewed - some kind of system for us to predict when a certain change might be reviewed - weekly report to the community explaining the review metrics - reviewed, in review, rejected, pending - add more reviewers, preferably from the community

-Varun

-----Original Message----- From: Joanna Farley Joanna.Farley@arm.com Sent: Friday, January 17, 2020 3:12 AM To: Varun Wadekar vwadekar@nvidia.com; tf-a@lists.trustedfirmware.org Subject: Re: [TF-A] Gerrit review latency

External email: Use caution opening links or attachments

Hi Varun,

It can be a challenge to keep on top of the reviews and we are aware of the backlog increase after the end of year break and trying different approaches to get reviews completed.

Any suggestions on process improvements from the developer community at large are welcome.

Cheers

Joanna

On 16/01/2020, 17:34, "TF-A on behalf of Varun Wadekar via TF-A" <tf-a-bounces@lists.trustedfirmware.org on behalf of tf-a@lists.trustedfirmware.org> wrote:

Hello,

We (NVIDIA) frequently post changes on the TF-A gerrit dashboard and wait for the maintainers to gradually get to them. This is very time consuming and non-deterministic.

Curious to know if other developers face the same problems or are we missing something when asking for reviews? If most of us face the same problems, then we should try to formulate a process to reduce the latency.

Thoughts?

-Varun

----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- -- TF-A mailing list TF-A@lists.trustedfirmware.org https://lists.trustedfirmware.org/mailman/listinfo/tf-a

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.