Hi Shawn,

I'll update the code to only change the FIFO threshold if a particular platform needs to change it.

A note is that in your platform, uboot can set the fifoth_val if your particular platform needs a specific threshold value. If you need further information: https://github.com/u-boot/u-boot/blob/master/drivers/mmc/socfpga_dw_mmc.c

Thanks Tien Hock

-----Original Message----- From: Shawn Guo shawn.guo@linaro.org Sent: Monday, June 3, 2019 5:19 PM To: Loh, Tien Hock tien.hock.loh@intel.com Cc: tf-a@lists.trustedfirmware.org Subject: Regression on Poplar eMMC

Hi Tien,

We recently found a regression on Poplar eMMC in U-Boot, which seems caused by commit 3d0f30bb544a ("drivers: synopsys: Fix synopsys MMC driver"). For some reason, the setup of FIFO threshold breaks eMMC support in U-Boot [1]. Would you please suggest a sensible fix for this regression? Thanks.

Shawn

[1] https://discuss.96boards.org/t/uboot-mmc-init-problem/8130/3